fix(dashboard): use _total suffix for nautobot change counters#71
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Render Events dashboard queries were updated in both dashboard JSON copies to use the new ChangesRender Events panel metric rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The Render Events panels queried the bare counter names (nv_config_manager_nautobot_change_messages_processed / _failed), but prometheus_client exposes counters with a _total suffix, so the series never matched and the panels rendered no data in any namespace. Append _total so the queries resolve. Signed-off-by: Davesh Mathur <daveshm@nvidia.com>
d0da593 to
972f35c
Compare
Collaborator
|
lgtm, if you can please rebase and run unit tests i'll approve |
zsblevins
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nv_config_manager_nautobot_change_messages_processed/_failed.prometheus_clientexposes counters with a_totalsuffix (the live series are..._processed_total/..._failed_total), so these expressions never matched and the panels showed no data in any namespace (verified against live Prometheus)._totalso the queries resolve. Applied to both the deployed chart copy and the docs copy.Verification
nv_config_manager_nautobot_change_messages_processed_total(and_failed_total) exist and carry data in active namespaces.Notes
src/nv_config_manager/render/dispatch.pyalready use thenv_config_manager_namespace.Summary by CodeRabbit