Skip to content

Rename IR to IQR in */ir/absolute and */ir/relative tags#385

Open
oleksandr-pavlyk wants to merge 1 commit into
NVIDIA:mainfrom
oleksandr-pavlyk:rename-ir-to-iqr-in-tags
Open

Rename IR to IQR in */ir/absolute and */ir/relative tags#385
oleksandr-pavlyk wants to merge 1 commit into
NVIDIA:mainfrom
oleksandr-pavlyk:rename-ir-to-iqr-in-tags

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Collaborator

This is a follow up to #379.

It follows up with @fbusato feedback to replace using IR abbreviation used to represent interquartile-range with more conventional IQR acronym. It was changed in the "name" and "description" values, but not in the tag name itself.

This PR replaced it in the tag names too, and renames variables that used the abbreviation in their names.

@oleksandr-pavlyk oleksandr-pavlyk requested a review from fbusato June 4, 2026 16:23
@oleksandr-pavlyk oleksandr-pavlyk added the type: cleanup Modernization, dead code removal, style fixes, etc. label Jun 4, 2026
@oleksandr-pavlyk oleksandr-pavlyk self-assigned this Jun 4, 2026
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 4, 2026
@oleksandr-pavlyk oleksandr-pavlyk moved this from Todo to In Review in CCCL Jun 4, 2026
@oleksandr-pavlyk oleksandr-pavlyk enabled auto-merge (squash) June 4, 2026 16:23
@oleksandr-pavlyk
Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

✅ Action performed

Full review finished.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Updated cold-measurement interquartile range (IQR) summary identifiers for improved naming consistency. Summary keys for both CPU and GPU metrics now use the full iqr designation instead of the abbreviated ir (e.g., nv/cold/time/cpu/iqr/absolute). Calculations remain unchanged.

Walkthrough

IQR summary identifiers and local variable names are standardized from ir to iqr across cold-measurement and CPU-only measurement code. Absolute summaries update key identifiers and corresponding variable names; relative summaries update key identifiers only. Underlying quartile calculations remain unchanged.

Changes

IQR key standardization

Layer / File(s) Summary
Cold measurement IQR rename
nvbench/detail/measure_cold.cu
CPU and GPU cold-measurement summaries: absolute summaries rename keys from .../ir/absolute to .../iqr/absolute and variables from cpu_time_ir to cpu_time_iqr and cuda_time_ir to cuda_time_iqr; relative summaries rename keys from .../ir/relative to .../iqr/relative. IQR calculations (Q3 − Q1) remain unchanged.
CPU-only measurement IQR rename
nvbench/detail/measure_cpu_only.cxx
CPU-only measurement summaries: absolute summary renames key from .../ir/absolute to .../iqr/absolute and variable from cpu_ir to cpu_iqr; relative summary renames key from .../ir/relative to .../iqr/relative. IQR calculation (Q3 − Q1) remains unchanged.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Infer (1.2.0)
nvbench/detail/measure_cpu_only.cxx

nvbench/detail/measure_cpu_only.cxx:19:10: fatal error: 'nvbench/benchmark_base.cuh' file not found
19 | #include <nvbench/benchmark_base.cuh>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Error: the following clang command did not run successfully:
/opt/infer-linux-x86_64-v1.2.0/lib/infer/facebook-clang-plugins/clang/install/bin/clang-18
@/tmp/coderabbit-infer/62350c9d7cfbc391fda172b6f7d44017bb82f402-51e77a3297a9ff2c/tmp/clang_command_.tmp.36e10d.txt
++Contents of '/tmp/coderabbit-infer/62350c9d7cfbc391fda172b6f7d44017bb82f402-51e77a3297a9ff2c/tmp/clang_command_.tmp.36e10d.txt':
"-cc1" "-load"
"/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../../facebook-clang-plugins/libtooling/build/FacebookClangPlugin.dylib"
"-add-plugin" "BiniouASTExporter" "-plugin-arg-BiniouASTExporter" "-"
"-plugin-arg-BiniouASTExporter" "PREPEND_CURRENT_DIR=1"
"-plugin-arg-BiniouASTExporter" "MAX_STRING_SIZE=65535" "-cc1" "-triple"
"x86_64-unknown-li

... [truncated 1131 characters] ...

lib/clang/18/include"
"-internal-isystem" "/usr/local/include" "-internal-isystem"
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include"
"-internal-externc-isystem" "/usr/include/x86_64-linux-gnu"
"-internal-externc-isystem" "/include" "-internal-externc-isystem"
"/usr/include" "-Wno-ignored-optimization-argument" "-Wno-everything"
"-fdeprecated-macro" "-ferror-limit" "19" "-fgnuc-version=4.2.1"
"-fskip-odr-check-in-gmf" "-fcxx-exceptions" "-fexceptions"
"-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o"
"/tmp/coderabbit-infer/51e77a3297a9ff2c/file.o" "-x" "c++"
"nvbench/detail/measure_cpu_only.cxx" "-O0" "-fno-builtin" "-include"
"/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../lib/clang_wrappers/global_defines.h"
"-Wno-everything"


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
nvbench/detail/measure_cold.cu (1)

298-303: ⚡ Quick win

suggestion: nvbench/detail/measure_cold.cu now uses only nv/.../iqr/... summary keys (no .../ir/... matches remain in the repo); consider an alias/deprecation note for external golden outputs or downstream tooling that may still reference .../ir/....


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1f97f429-f169-4722-b1d3-37a53c2ef001

📥 Commits

Reviewing files that changed from the base of the PR and between 56d5526 and 62350c9.

📒 Files selected for processing (2)
  • nvbench/detail/measure_cold.cu
  • nvbench/detail/measure_cpu_only.cxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: cleanup Modernization, dead code removal, style fixes, etc.

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant