Rename IR to IQR in */ir/absolute and */ir/relative tags#385
Rename IR to IQR in */ir/absolute and */ir/relative tags#385oleksandr-pavlyk wants to merge 1 commit into
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughIQR summary identifiers and local variable names are standardized from ChangesIQR key standardization
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)nvbench/detail/measure_cpu_only.cxxnvbench/detail/measure_cpu_only.cxx:19:10: fatal error: 'nvbench/benchmark_base.cuh' file not found ... [truncated 1131 characters] ... lib/clang/18/include" Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
nvbench/detail/measure_cold.cu (1)
298-303: ⚡ Quick winsuggestion:
nvbench/detail/measure_cold.cunow uses onlynv/.../iqr/...summary keys (no.../ir/...matches remain in the repo); consider an alias/deprecation note for external golden outputs or downstream tooling that may still reference.../ir/....
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1f97f429-f169-4722-b1d3-37a53c2ef001
📒 Files selected for processing (2)
nvbench/detail/measure_cold.cunvbench/detail/measure_cpu_only.cxx
This is a follow up to #379.
It follows up with @fbusato feedback to replace using IR abbreviation used to represent interquartile-range with more conventional IQR acronym. It was changed in the "name" and "description" values, but not in the tag name itself.
This PR replaced it in the tag names too, and renames variables that used the abbreviation in their names.