Skip to content

fix(release): accept source charts from main and chart maintenance branches [nvcf-compute-plane 1.0] - #2989

Merged
kristinapathak merged 1 commit into
release-deploy/stacks/nvcf-compute-plane/v1.0from
kristinapathak/cp-v1.0-inventory-fixes
Oct 29, 2026
Merged

kristinapathak merged 1 commit into
release-deploy/stacks/nvcf-compute-plane/v1.0from
kristinapathak/cp-v1.0-inventory-fixes

Conversation

@kristinapathak

Copy link
Copy Markdown
Collaborator

TL;DR

Ports the chart release branch check from #2974 to the compute-plane 1.0 train. A patch on this train can pin a helm-nvca-operator version released after the train split from main. The stack inventory now accepts that chart tag when origin/main or the chart's maintenance branch contains it, so the patch still gets its inventory.

Additional Details

Why:

What changed:

  • If a pinned chart tag is not an ancestor of the stack commit, docs-version-sync accepts it when origin/main or origin/release-<tag prefix>X.Y for the tag's minor contains it. It logs that branch to stderr. chartReleaseBranchContaining is the same code as on main.
  • Any other tag still fails: a tag on an unmerged branch, on another chart's maintenance branch, or on the wrong minor's branch.

Not ported:

This changes nothing under deploy/stacks/nvcf-compute-plane, so merging it does not cut a new stack patch. Not customer visible. No dependency changes.

For the Reviewer

For QA

  • go test ./... in tools/docs-version-sync: pass.
  • python3 tools/ci/test-github-release.py: pass (98 tests).
  • go vet ./..., gofmt -l, and git diff --check: clean.
  • Ran the inventory's source chart step against the real deploy/stacks/nvcf-compute-plane/v1.0.4 tag (stack commit aae64c9a1):
    • With the tag's own pin (helm-nvca-operator 1.28.0): pass, from the stack's own history.
    • With the pin moved to 1.29.6, released on main after the split: pass with this change (using the release from origin/main). Before it, it fails with is not an ancestor of stack commit.
  • No release-deploy/helm/nvca-operator/v1.X branch exists yet, so the unit test covers the maintenance branch case.
  • The full inventory render was not run locally. It pulls the stack's other charts from the release chart registry, which only the release workflow can reach.
  • QA needed: no. Release tooling only.

Issues

Relates to #2970
Relates to #2972

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

🤖 Generated with Claude Code

…anches [nvcf-compute-plane 1.0]

Port of the chart release branch check from #2974 to the compute-plane
1.0 train.

A patch on this train can pin a helm-nvca-operator version released
after the train split from main, on main or on the chart's maintenance
branch. That tag is not an ancestor of the stack commit, so the
inventory rejected it. The inventory now also accepts a chart tag that
origin/main or origin/release-<tag prefix>X.Y contains. Any other tag
is still rejected.

The snapshot lineage from #2971 and #2973 is not ported. This branch
continues main's history instead of starting from a release snapshot,
so chart tags released on main before the split are already ancestors
of its stack commits. The docs sections that #2974 edits are not on
this branch.

Relates to #2970
Relates to #2972

Signed-off-by: Kristina Pathak <kpathak@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kristinapathak kristinapathak self-assigned this Oct 28, 2026
@kristinapathak
kristinapathak requested a review from a team as a code owner October 28, 2026 19:04
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kristinapathak
kristinapathak merged commit 735351c into release-deploy/stacks/nvcf-compute-plane/v1.0 Oct 29, 2026
16 checks passed
@kristinapathak
kristinapathak deleted the kristinapathak/cp-v1.0-inventory-fixes branch October 29, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants