Repository navigation
fix(self-managed): pin cloud-functions 1.33.1 for worker-utils 1.4.2 [self-managed 1.1] - #3003
Closed
shobham-nv wants to merge 1 commit into
Closed
shobham-nv wants to merge 1 commit into
shobham-nv wants to merge 1 commit into
Conversation
…[self-managed 1.1] Signed-off-by: shobham <shobham@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
4 tasks done
Contributor
Author
|
Folded into #3013, so both fixes ship in one 1.1 patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backports the worker-utils NATS reconnect fixes to the self-managed 1.1 stack by moving the
api(cloud-functions) chart pin from 1.33.0 to 1.33.1, the chart patch that defaults worker-utils to 1.4.2.Draft: cloud-functions 1.33.1 is not released yet. It comes from #3002, which is waiting on QA re-verification of worker-utils 1.4.2. If that release ends up with a different version, this pin will be updated to match.
Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl:api1.33.0->1.33.1.api.remoteConfig.workerImageTags.utils"1.3.3"->"1.4.2". The 1.1 stack does not override that value, so function workers launched by 1.1 start getting worker-utils 1.4.2.For the Reviewer
For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
utils-container-imageset tonvcf-worker-utils-oss:1.4.2.Issues
Relates to #2832.
Checklist