Skip to content

fix(cloud-functions): default nvcf-api to 1.28.2 for the Cassandra replica-down fixes - #3012

Merged
shobham-nv merged 1 commit into
mainfrom
shobham/cloud-functions-nvcf-api-1.28.2
Oct 29, 2026
Merged

shobham-nv merged 1 commit into
mainfrom
shobham/cloud-functions-nvcf-api-1.28.2

Conversation

@shobham-nv

@shobham-nv shobham-nv commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR

Moves the cloud-functions chart's default nvcf-api image from 1.28.0 to 1.28.2, so self-managed installs get the Cassandra replica-down fixes from #2918. No chart release so far carries them.

Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)

For the Reviewer

For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)

  • helm lint deploy/helm/cloud-functions/nvcf-api passes.
  • On a self-managed HA setup with Cassandra 0.23.2 and this chart, run function lookup traffic and kill -9 the Cassandra process on one node. Expect no stall longer than about 5 s, and no 500s from read timeouts.

Issues

Relates to #2893.

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

…plica-down fixes

1.28.2 carries #2918: range read timeouts retry on the next host when the
ncp profile selects RangeReadRetryPolicy, and retriable Cassandra failures
return 503 with Retry-After instead of a 500 with CQL. It also picks up
#2966 (/info version after config refresh).

Relates to #2893

Signed-off-by: shobham <shobham@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 59a62df and 86960f4.

Files selected for processing: 2
  • deploy/helm/cloud-functions/nvcf-api/Chart.yaml
  • deploy/helm/cloud-functions/nvcf-api/values.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

Walkthrough

The nvcf-api Helm chart now sets its appVersion and default API image tag to 1.28.2.

Changes: nvcf-api release

Layer / File(s) Summary
Update chart and image versions
deploy/helm/cloud-functions/nvcf-api/Chart.yaml, deploy/helm/cloud-functions/nvcf-api/values.yaml
The chart’s appVersion and default api.image.tag change from 1.28.0 to 1.28.2.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • NVIDIA/nvcf#2939: Updates the same chart fields from 1.27.7 to 1.28.0.
  • NVIDIA/nvcf#2764: Updates the same nvcf-api chart fields in an earlier release bump.
  • NVIDIA/nvcf#2918: Implements behavior included in the 1.28.2 API image selected by this update.

Suggested reviewers: balajinvda

Merge Risk: Minimal · up to 86960

No actionable merge-blocking risk was identified in this version-only chart update.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title uses the required Conventional Commits format, includes the required scope for a customer-impacting fix, and accurately describes the nvcf-api version update for Cassandra replica-down fixes…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title uses the required Conventional Commits format, includes the required scope for a customer-impacting fix, and accurately describes the nvcf-api version update for Cassandra replica-down fixes.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@shobham-nv
shobham-nv added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit e6ecac1 Oct 29, 2026
22 checks passed
@shobham-nv
shobham-nv deleted the shobham/cloud-functions-nvcf-api-1.28.2 branch October 29, 2026 18:36
@balajinvda

Copy link
Copy Markdown
Contributor

🎉 This PR is included in deploy/helm/cloud-functions/v1.33.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

along-2017 added a commit that referenced this pull request Oct 29, 2026
Chart 1.33.2 is the release cut from #3012. It moves nvcf-api to 1.28.2 for the Cassandra replica-down fixes from #2918.

Signed-off-by: along <along@nvidia.com>
@balajinvda

Copy link
Copy Markdown
Contributor

This PR is included in version 1.37.3.

The release is available on GitHub release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants