Skip to content

Bump google.golang.org/grpc from 1.57.1 to 1.79.3#1817

Merged
cdesiniotis merged 1 commit into
NVIDIA:release-1.19from
cdesiniotis:bump-grpc-1.79.3
May 11, 2026
Merged

Bump google.golang.org/grpc from 1.57.1 to 1.79.3#1817
cdesiniotis merged 1 commit into
NVIDIA:release-1.19from
cdesiniotis:bump-grpc-1.79.3

Conversation

@cdesiniotis
Copy link
Copy Markdown
Contributor

No description provided.

@cdesiniotis cdesiniotis requested review from tariq1890 and removed request for tariq1890 May 11, 2026 18:17
@tariq1890
Copy link
Copy Markdown
Contributor

The grpc dependency is indirect. Do we know which direct dependency of the toolkit brings grpc to the dependency tree?

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25688988089

Coverage remained the same at 43.325%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14862
Covered Lines: 6439
Line Coverage: 43.33%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

@cdesiniotis
Copy link
Copy Markdown
Contributor Author

The grpc dependency is indirect. Do we know which direct dependency of the toolkit brings grpc to the dependency tree?

github.com/containerd/nri/pkg/api which unfortunately has not updated the grpc dependency yet https://github.com/containerd/nri/blob/520641efc61c07ccb5a39b13dcfe5598ab1f9ab9/go.mod#L20. There is a critical CVE in this package which will block our release.

@tariq1890
Copy link
Copy Markdown
Contributor

Got it. Thanks for the context. Let me take a look at the NRI repo and see how grpc is used here (my impression was that NRI uses ttrpc and not grpc). We might need to run a quick test to ensure the NRI plugin feature isn't impacted by this

Copy link
Copy Markdown
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a safe bump

@cdesiniotis
Copy link
Copy Markdown
Contributor Author

Thanks for checking!

@cdesiniotis cdesiniotis merged commit 6a0129c into NVIDIA:release-1.19 May 11, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants