add support for injecting /dev/dri* devices nodes for gfx MIGs#1818
Conversation
6111e01 to
dd035c8
Compare
Coverage Report for CI Build 25753963182Coverage decreased (-0.05%) to 43.296%Details
Uncovered Changes
Coverage Regressions21 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
elezar
left a comment
There was a problem hiding this comment.
This looks reasonable @tariq1890. Could we link the related go-nvlib PRs that will be required for this in the description?
One other thing to note. This handles the injection of these devices when nvidiasandbox-utils is used, but not when pure nvml is used. Is this a concern?
|
Thanks for the review @elezar . There are no go-nvlib or go-nvml changes required for this PR. These toolkit changes just work as they are. Regarding the NVML discoverer, I thought the changes would just work looking at the code. I can try testing that with the nvsandboxutils discoverer disabled |
|
I stand corrected :). Changes are indeed needed in the NVML MIG discoverer. I'll make those changes |
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
dd035c8 to
881be27
Compare
This is now addressed. I was able to confirm through local testing that the pure NVML discoverer will inject the |
|
/cherry-pick release-1.19 |
|
🤖 Backport PR created for |
Currently, the container toolkit skips adding the
/dev/dridevice nodes to a device if it's found to be a MIG device. Today, with the availability of GPUs like RTX Pro 6000D Blackwell, MIG slices with graphics capabilities can be created.In this PR, we update the NVSandboxutils and NVML discoverers to check if the detected MIG device supports graphics and inject the
/dev/dridevice nodes if true.