[cri-o config] fix drop-in config directory used for config overrides

[tariq1890]

As per the official CRI-O documentation, the cri-o runtime configuration overrides via drop-in files only work if they are placed under the /etc/crio/crio.conf.d directory. The current default drop-in config directory /etc/crio/conf.d will not be recognised by CRI-O and therefore, the configs will not be applied

[coveralls]

Coverage Report for CI Build 25906231168

Coverage remained the same at 43.342%

Details

• Coverage remained the same as the base build.
• Patch coverage: No coverable lines changed in this PR.
• No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	14861
Covered Lines:	6441
Line Coverage:	43.34%
Coverage Strength:	0.48 hits per line

---

💛 - Coveralls

[elezar]

Thanks @tariq1890. We obviously carried the value over from the initial implementation in #1272 and never validated it.

As a follow-up, what are our ideas about testing drop-in files in crio? Also, I suppose that a user can always override this, so we have a workaround that can be applied. Is there a need to backport this?

[cdesiniotis]

Thanks @tariq1890. We do not rely on the default value in the GPU Operator, which explains why we haven't run into any issues there: https://github.com/NVIDIA/gpu-operator/blob/6888f3b7c079719f472fa25d91c955dbff54deb8/controllers/object_controls.go#L81

[cdesiniotis]

/cherry-pick release-1.19

[tariq1890]

@elezar I think we do need to backport this. As @cdesiniotis pointed out, the gpu-operator deployments are not affected by this. However, users who setup toolkit directly on hosts with CRI-O as the container runtime will need this fix

[github-actions]

🤖 Backport PR created for release-1.19: #1830 ✅