Skip to content

Add feature to require kernel module#764

Closed
elezar wants to merge 2 commits into
NVIDIA:mainfrom
elezar:add-feature-to-require-kernel-module
Closed

Add feature to require kernel module#764
elezar wants to merge 2 commits into
NVIDIA:mainfrom
elezar:add-feature-to-require-kernel-module

Conversation

@elezar
Copy link
Copy Markdown
Member

@elezar elezar commented Oct 30, 2024

This change adds a require-nvidia-kernel-modules feature flag that allows the logic for checking whether the nvidia kernel modules are loaded to be incorportated into the runtime itself.

This has the following advantages:

  1. It allows support for platforms that don't have a shell (see Replace shell wrapper with a Go wrapper #700)
  2. It allows low-level runtimes other than runc to be used.

This change adds an opt-in feature to the NVIDIA Container Runtime that
only uses the NVIDIA runtime if the NVIDIA kernel modules are loaded.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the add-feature-to-require-kernel-module branch from bf34b13 to ac61306 Compare October 30, 2024 14:22
@elezar elezar requested a review from tariq1890 October 30, 2024 15:39
@elezar elezar marked this pull request as ready for review October 30, 2024 15:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 5, 2025

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2025
@github-actions github-actions Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2025
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2026
@rajatchopra
Copy link
Copy Markdown

Closing out this PR.

Reasoning: While this feature is still useful to ensure the modified spec is called with the runtime only when environment is conducive, this path is less prominent with the advent of CDI.

Please re-open if anyone feels otherwise. The base code has been refactored quite a bit since the original PR also, so the work likely needs to be redone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants