Add feature to require kernel module#764
Conversation
This change adds an opt-in feature to the NVIDIA Container Runtime that only uses the NVIDIA runtime if the NVIDIA kernel modules are loaded. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
bf34b13 to
ac61306
Compare
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
|
Closing out this PR. Reasoning: While this feature is still useful to ensure the modified spec is called with the runtime only when environment is conducive, this path is less prominent with the advent of CDI. Please re-open if anyone feels otherwise. The base code has been refactored quite a bit since the original PR also, so the work likely needs to be redone. |
This change adds a
require-nvidia-kernel-modulesfeature flag that allows the logic for checking whether thenvidiakernel modules are loaded to be incorportated into the runtime itself.This has the following advantages:
runcto be used.