Skip to content

Register AI-Q Blueprint skills#60

Closed
exactlyallan wants to merge 1 commit into
NVIDIA:mainfrom
exactlyallan:allan/register-aiq-skills
Closed

Register AI-Q Blueprint skills#60
exactlyallan wants to merge 1 commit into
NVIDIA:mainfrom
exactlyallan:allan/register-aiq-skills

Conversation

@exactlyallan
Copy link
Copy Markdown

@exactlyallan exactlyallan commented May 19, 2026

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)

For new product onboarding - author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).

Other context

Registers components.d/aiq.yml so the skills catalog sync can mirror both public AI-Q Blueprint skills from NVIDIA-AI-Blueprints/aiq.

Catalog entries:

  • skills/aiq-research/ -> skills/aiq-research/
  • skills/aiq-deploy/ -> skills/aiq-deploy/

The entry currently targets ref: develop because the AIQ skills update is landing there first. Move this to main or a stable release branch once AIQ stabilizes there.

Validation:

  • Parsed components.d/aiq.yml with the Ruby standard YAML parser.
  • Ran git diff --check.
  • Confirmed the local AIQ skill branch contains direct SKILL.md entrypoints for skills/aiq-research/ and skills/aiq-deploy/.
  • Ran a dry-run rsync check that copies each source skill path into its catalog directory without nested duplicate skill folders.

@exactlyallan exactlyallan changed the title Add AI-Q Blueprint skills component Add aiq-research skills component May 19, 2026
@exactlyallan exactlyallan marked this pull request as ready for review May 19, 2026 18:45
@exactlyallan
Copy link
Copy Markdown
Author

Note: working to update source skill to meet signing reqs.

Register aiq-research and aiq-deploy as separate catalog entries synced from NVIDIA-AI-Blueprints/aiq develop.

Signed-off-by: Allan Enemark <aenemark@nvidia.com>
@exactlyallan exactlyallan force-pushed the allan/register-aiq-skills branch from 0fb99ec to ec05671 Compare May 22, 2026 20:03
@exactlyallan exactlyallan changed the title Add aiq-research skills component Register AI-Q Blueprint skills May 22, 2026
Copy link
Copy Markdown
Collaborator

@mosheabr mosheabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Allan — great progress since my first review on 2026-05-19. Both blockers from before are resolved:

First-review blocker Now
Author email was Gmail (exactly.allan@gmail.com) ✅ Fixed — aenemark@nvidia.com
No signing artifacts on AIQ skills ✅ Fixed — both aiq-research/ and aiq-deploy/ carry skill.oms.sig + skill-card.md on develop

Also confirmed both skills ship evals/evals.json (required per v4 onboarding guide Step 2: "Skills must ship with an evals/ directory next to SKILL.md"). Nicely done.

One remaining blocker — slug mismatch:

name: AI-Q Blueprint lowercased with spaces→dashes derives to ai-q-blueprint, but the file is aiq.yml. Per anti-pattern #3, this breaks the auto-generated README version-cell patcher (which keys on the name-derived slug, not the filename).

Pick one of these — they're all valid:

  1. name: AIQ + keep filename aiq.yml ← cleanest, aligns with your catalog_dir naming (aiq-research, aiq-deploy)
  2. name: AIQ Blueprint + rename file to aiq-blueprint.yml
  3. Keep name: AI-Q Blueprint + rename file to ai-q-blueprint.yml

Option 1 is the lowest-friction.

One small thing to flag:

PR is from your fork (exactlyallan/skills), so CI workflows are still gated and haven't reported. Once you push the slug fix, a maintainer needs to approve the workflow run — DCO + verify-authors will both pass based on your current commit metadata.

Once the slug is fixed and CI lands green, this is ready to merge.

@AjayThorve
Copy link
Copy Markdown
Contributor

can close this in favor of #99

@mosheabr
Copy link
Copy Markdown
Collaborator

Hi Allan — thanks for kicking this off back in May. Ajay Thorve's PR #99 came in this evening as a clean replacement that landed all the feedback from my earlier reviews (slug fixed to AIQ → aiq, source moved to main, both skills carry sig + card + evals.json). PR #99 is now merged so I'm closing this one to keep the history clean.

Closing as superseded by #99.

@mosheabr mosheabr closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants