Enforce skill.oms.sig and skill-card.md in sync pipeline#83
Merged
Conversation
f347283 to
b5f5881
Compare
Skills missing either file are now dropped from the catalog before the sync PR is opened, replacing the prior informational-only signature scan. Dropped skills are listed in the PR body and tracked under a new missing-compliance issue label. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sayali Kandarkar <skandarkar@nvidia.com>
b5f5881 to
b4b9580
Compare
Collaborator
Author
After per-skill compliance enforcement, also remove any top-level product directory under skills/ that contains no SKILL.md anywhere inside. Avoids leaving misleading empty/helper-only folders in the catalog (e.g. a placeholder with only a README, or a product whose every skill was dropped for non-compliance). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sayali Kandarkar <skandarkar@nvidia.com>
Collaborator
Author
mosheabr
approved these changes
May 26, 2026
Collaborator
mosheabr
left a comment
There was a problem hiding this comment.
Approved per catalog-pr-reviewer checklist.
Scope is correct: one workflow file (+79/-29), per-skill compliance enforcement, orphan-product cleanup, tracking issue under missing-compliance label. DCO + verify-authors both green. The diff also auto-marks products with dropped skills as 'changed' so the sync PR opens even when the only diff is a removal — good catch on the previously-compliant-now-non-compliant case.
Aligns with the 2026-05-27 signing-baseline cutover we communicated to product teams.
LGTM — over to you on when to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
skill.oms.sigorskill-card.mdare now dropped from the catalog before the sync PR is opened — compliance is no longer informational/opt-in.missing-compliance(auto-updates each sync, auto-closes when everything is compliant).What changed
rm -rfs non-compliant skill directories (sync-skills.yml:141-178).missing-compliancelabel, replacing the oldermissing-signatureslabel (sync-skills.yml:180-237).Test plan
workflow_dispatchand confirm:cuopt/cuopt-numerical-optimization-api-cli— has both files) sync through normally🤖 Generated with Claude Code