Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .claude/CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ These structures propagate across every provider and engine. Changing them in a

### Prerequisites

- **Go 1.25.9** (see `go.mod`) — newer minor versions are fine; older will not build
- **Go 1.25.11** (see `go.mod`) — newer minor versions are fine; older will not build
- **make**
- **golangci-lint** — `brew install golangci-lint` or via `go install`
- **helm 3.10+ or 4.x** — required for `make chart-test`; the `helm-unittest` plugin is installed automatically by the target (`brew install helm`). CI pins helm `v4.1.1` in `.github/workflows/chart-test.yaml`.
Expand Down Expand Up @@ -105,7 +105,7 @@ Coverage checks run on pull requests. A drop below target with no matching uplif

### CI workflows

- `.github/workflows/go.yml` — build, test, and lint on every push and PR
- `.github/workflows/go.yml` — build, test, lint, and `govulncheck` on every push and PR
- `.github/workflows/chart-test.yaml` — Helm chart lint + helm-unittest suites (`make chart-test`) on every push and PR
- `.github/workflows/docker.yml` — container image build (manual trigger)
- `.github/workflows/helm-release.yaml` — Helm chart release (manual trigger)
Expand Down
21 changes: 18 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: '1.25.9'
go-version: '1.25.11'

- name: Lint
uses: golangci/golangci-lint-action@v9
Expand All @@ -42,7 +42,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: '1.25.9'
go-version: '1.25.11'

- name: Test
run: go test -v -coverpkg=./... -coverprofile=coverage.out -covermode=atomic ./...
Expand All @@ -63,8 +63,23 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: '1.25.9'
go-version: '1.25.11'

- name: Build
run: |
make build

govulncheck:
runs-on: linux-amd64-cpu8
timeout-minutes: 15
steps:
- uses: actions/checkout@v5

- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: '1.25.11'
cache: true

- name: Run govulncheck
run: go run golang.org/x/vuln/cmd/govulncheck@v1.1.4 ./...
4 changes: 2 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ These structures propagate across every provider and engine. Changing them in a

### Prerequisites

- **Go 1.25.9** (see `go.mod`) — newer minor versions are fine; older will not build
- **Go 1.25.11** (see `go.mod`) — newer minor versions are fine; older will not build
- **make**
- **golangci-lint** — `brew install golangci-lint` or via `go install`
- **helm 3.10+ or 4.x** — required for `make chart-test`; the `helm-unittest` plugin is installed automatically by the target (`brew install helm`). CI pins helm `v4.1.1` in `.github/workflows/chart-test.yaml`.
Expand Down Expand Up @@ -105,7 +105,7 @@ Coverage checks run on pull requests. A drop below target with no matching uplif

### CI workflows

- `.github/workflows/go.yml` — build, test, and lint on every push and PR
- `.github/workflows/go.yml` — build, test, lint, and `govulncheck` on every push and PR
- `.github/workflows/chart-test.yaml` — Helm chart lint + helm-unittest suites (`make chart-test`) on every push and PR
- `.github/workflows/docker.yml` — container image build (manual trigger)
- `.github/workflows/helm-release.yaml` — Helm chart release (manual trigger)
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

### Added

- `govulncheck` job in the Go CI workflow for symbol-level vulnerability scanning on pull requests.
- OCI labels missing from `docker/metadata-action` on the Topograph container image: `org.opencontainers.image.documentation`, `authors`, and `vendor` ([#377](https://github.com/NVIDIA/topograph/pull/377)).
- Helm chart metadata: `home`, `icon`, `maintainers`, `keywords`, and Artifact Hub annotations ([#377](https://github.com/NVIDIA/topograph/pull/377)).

### Changed

- Go toolchain bumped to **1.25.11** (`go.mod`, `Dockerfile`, CI) to address reachable stdlib vulnerabilities reported by `govulncheck`.

### Fixed

- Helm node-observer now targets the rendered Topograph Service fullname in `generateTopologyUrl`.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.25.9 AS builder
FROM golang:1.25.11 AS builder

WORKDIR /go/src/github.com/NVIDIA/topograph
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/NVIDIA/topograph

go 1.25.9
go 1.25.11

require (
cloud.google.com/go/compute v1.60.0
Expand Down
Loading