Remove chai-as-promised

Author: nonword

bin/nypl-data-api.js

@@ -27,7 +27,8 @@ const printResponse = (resp) => {
     // If JSON, format as json, otherwise print as-is:
     try { Object.keys(resp).length >= 1 && (formattedResponse = JSON.stringify(resp, null, 2)) } catch (e) { }
   }
-  console.log('Response: \n', formattedResponse)
+  console.log('Response:')
+  console.log(formattedResponse)
 
   // Detect the distinct API Gateway bad-request-path error:
   if (resp?.message?.includes(' not a valid key=value pair ')) {

package-lock.json

@@ -21,7 +21,6 @@
   },
   "devDependencies": {
     "chai": "^4.1.2",
-    "chai-as-promised": "^7.1.1",
     "jsdoc-to-markdown": "^8.0.1",
     "mocha": "^10.4.0",
     "prompts": "^2.4.2",

package.json

@@ -1,10 +1,8 @@
 const oauth = require('oauth')
 const sinon = require('sinon')
 const chai = require('chai')
-const chaiAsPromised = require('chai-as-promised')
 const { fixtureForRequest } = require('./fixtures')
 
-chai.use(chaiAsPromised)
 global.expect = chai.expect
 
 let _fetchSpy

test/helper.js

@@ -1,3 +1,4 @@
+const { rejects } = require('node:assert/strict')
 const { fetchSpy } = require('./helper')
 
 let client = null
@@ -43,20 +44,23 @@ describe('Client PATCH method', function () {
 
     it('should fail if supplied body is plaintext', async () => {
       const call = client.patch('hold-requests/1234', JSON.stringify(holdRequestPatch))
-      await expect(call).to.be.rejectedWith('Attempted to PATCH with options.json==true, but body is a string')
+      return rejects(call, {
+        name: 'RequestError',
+        message: 'Attempted to PATCH with options.json==true, but body is a string'
+      })
     })
 
     // A null/empty body should be accepted as valid if options.json===true
     it('should succeed if supplied body is empty', async () => {
-      const call = client.patch('hold-requests/1234')
-      await expect(call).to.be.eventually.be.a('object')
+      const call = await client.patch('hold-requests/1234')
+      expect(call).to.be.a('object')
     })
   })
 
   describe('when config.json=false', () => {
     it('should accept a plaintext body and return plain text', async () => {
-      const call = client.patch('hold-requests/1234', JSON.stringify(holdRequestPatch), { json: false })
-      await expect(call).to.eventually.be.a('string')
+      const res = await client.patch('hold-requests/1234', JSON.stringify(holdRequestPatch), { json: false })
+      await expect(res).be.a('string')
     })
   })
 })

test/patch-test.js

@@ -1,3 +1,4 @@
+const { rejects } = require('node:assert/strict')
 const { fetchSpy } = require('./helper')
 
 let client = null
@@ -47,20 +48,23 @@ describe('Client POST method', function () {
 
     it('should fail if supplied body is plaintext', () => {
       const call = client.post(`schemas/${testSchema.name}`, JSON.stringify(testSchema))
-      return expect(call).to.be.rejectedWith('Attempted to POST with options.json==true, but body is a string')
+      return rejects(call, {
+        name: 'RequestError',
+        message: 'Attempted to POST with options.json==true, but body is a string'
+      })
     })
 
     // A null/empty body should be accepted as valid if options.json===true
-    it('should succeed if supplied body is empty', () => {
-      const call = client.post(`schemas/${testSchema.name}`)
-      return expect(call).to.be.fulfilled
+    it('should succeed if supplied body is empty', async () => {
+      const resp = await client.post(`schemas/${testSchema.name}`)
+      return expect(resp).to.deep.eq({ data: { stream: 'TestSchema' } })
     })
   })
 
-  describe('when config.json=false', () => {
-    it('should accept a plaintext body and return plain text', () => {
-      const call = client.post(`schemas/${testSchema.name}`, JSON.stringify(testSchema), { json: false })
-      return expect(call).to.eventually.be.a('string')
+  describe('when config.json=false', async () => {
+    it('should accept a plaintext body and return plain text', async () => {
+      const call = await client.post(`schemas/${testSchema.name}`, JSON.stringify(testSchema), { json: false })
+      expect(call).to.be.a('string')
     })
   })
 })