fix: resolve reserve association issues and handle code base with recent r2x-reeds and r2x-sienna updates.

[mcllerena]

No description provided.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.01%. Comparing base (cba09db) to head (f21149e).

Files with missing lines	Patch %	Lines
...reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py	92.59%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   84.96%   85.01%   +0.05%     
==========================================
  Files          20       20              
  Lines        4655     4679      +24     
==========================================
+ Hits         3955     3978      +23     
- Misses        700      701       +1     

Files with missing lines	Coverage Δ
...reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py	88.43% <92.59%> (+0.45%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR updates the ReEDS→Sienna translation to correctly handle (1) reserve-type mapping/associations (including NON_SPINNING), (2) hydro-specific attributes (prime mover + reactive limits), and (3) new consuming-technology demand types (electrolyzer/datacenter) in line with recent r2x-reeds and r2x-sienna model changes.

Changes:

• Add explicit NON_SPINNING reserve mapping to VariableReserveNonSpinning and ensure generators attach the correct reserve services.
• Fix hydro translation to always use PrimeMoversType.HY and provide zeroed reactive_power_limits.
• Add translation rules + getters for ReEDSElectrolyzerDemand and ReEDSDataCenterDemand to InterruptiblePowerLoad, with expanded regression coverage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py	Adds new getters for hydro prime mover, reactive limits, generator reserve services, and consuming-technology load power fields.
packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/config/rules.json	Updates/extends translation rules for NON_SPINNING reserves, generator services attachment, hydro prime mover/reactive limits, and consuming-technology loads.
packages/r2x-reeds-to-sienna/tests/test_translation_rule_application.py	Adds integration/regression tests covering hydro attributes, reserve mapping, reserve-to-generator service attachment, and consuming-technology loads.
packages/r2x-reeds-to-sienna/tests/test_rules_loading.py	Adds rule-presence/structure assertions for the new reserve/load/hydro rule updates.
packages/r2x-reeds-to-sienna/tests/test_getters.py	Adds direct getter tests for gen services, non-spinning resolution, hydro prime mover, reactive limits, and consuming-technology power getters.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.