111 batch running features gpu runner#142
Draft
jmaack24 wants to merge 52 commits into
Draft
Conversation
…NativeRunner::report_simulation
…-running-features---gpu-runner
…o single structure
…op to leverage the structure better
…e SolTraceSystem::run
3 tasks
…ays traced to the runner api; implement and test these new function; add output statements to simdriver
Coverage Report for CI Build 26186442341Coverage decreased (-0.02%) to 86.244%Details
Uncovered Changes
Coverage Regressions4 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Comment on lines
+156
to
+158
| std::vector<HitRecord> m_hit_records; | ||
|
|
||
| // Global ray index (ray_offset + local_index) for each logical hit ray in m_hit_records. |
Member
Author
There was a problem hiding this comment.
Added error check in OptixRunner::setup_parameters to ensure that ray ids are less than uint32_t max value.
Member
Author
There was a problem hiding this comment.
Turns out this is needed for some of the round robin testing. Working on a fix.
Comment on lines
+19
to
+30
| # define SOLTRACE_SET_FTZ_DAZ() do { \ | ||
| uint64_t _fpcr = _ReadStatusReg(ARM64_FPCR); \ | ||
| _fpcr |= (1ULL << 24); \ | ||
| _WriteStatusReg(ARM64_FPCR, _fpcr); \ | ||
| } while(0) | ||
| # else | ||
| /* GCC / Clang on ARM64 */ | ||
| # define SOLTRACE_SET_FTZ_DAZ() do { \ | ||
| uint64_t _fpcr; \ | ||
| __asm__ __volatile__("mrs %0, fpcr" : "=r"(_fpcr)); \ | ||
| _fpcr |= (1ULL << 24); \ | ||
| __asm__ __volatile__("msr fpcr, %0" : : "r"(_fpcr)); \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement/do the following for the OptixRunner: