Sp/bug fixes - #13
Merged
Merged
Conversation
RHammond2
reviewed
Jun 3, 2026
Comment on lines
-1414
to
-1424
| #out, _ = find_breakeven( | ||
| # row=row, | ||
| # loan=loan, | ||
| # pysam_outputs=pysam_outputs, | ||
| # batt_costs=batt_costs, | ||
| # method="newton", | ||
| # pre_calc_bounds_and_tolerances=False, | ||
| # **{"x0": 10000.0, "full_output": True}, | ||
| #) | ||
| # | ||
| row["breakeven_cost_usd_p_kw"] = None |
Collaborator
There was a problem hiding this comment.
This change and the same for FOM would indicate a minor release (bumping the version by +0.1.0).
RHammond2
reviewed
Jun 3, 2026
RHammond2
reviewed
Jun 3, 2026
RHammond2
approved these changes
Jun 3, 2026
RHammond2
left a comment
RHammond2
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me, @spodgorny9. Just be sure to update the version in __init__.py to v0.5. Once merged, the repo can get tagged and released, which I'm happy to walk you through when you're ready.
Co-authored-by: Rob Hammond <13874373+RHammond2@users.noreply.github.com>
Co-authored-by: Rob Hammond <13874373+RHammond2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return to running on Kestrel: File path and Breakeven bug fixes
Fix files paths to ensure successful running on Kestrel. Temporarily reinstitute breakeven calculation to align with previous results. Calculation will be removed in the near future.
PR Checklist
CHANGELOG.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelease Checklist
OR
dwind/__init__.py::__version__have updated according to Semantic VersioningCHANGELOG.mdhas theUnreleasedsection converted to a release version number and release dateRelated issues
Impacted areas of the software
dwind/valuation.pyprocess_fom: Reincorporate breakeven calculation.process_btm: Reincorporate breakeven calculation.dwind/cli/collect.py-dwind/cli/run.py-dwind/scenarios.pyAdditional supporting information
Python version: 3.11
dwind version (
dwind.__version__): 0.5.1