Skip to content

OM Refactor: Promote Cell Design Parameters - #99

Merged
elenya-grant merged 5 commits into
NatLabRockies:developfrom
elenya-grant:om_refactor/promote_cell_params
Jul 30, 2026
Merged

OM Refactor: Promote Cell Design Parameters#99
elenya-grant merged 5 commits into
NatLabRockies:developfrom
elenya-grant:om_refactor/promote_cell_params

Conversation

@elenya-grant

@elenya-grant elenya-grant commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

OM Refactor: Promote Cell Design Parameters

This is a follow-on to PR #91 and aims to resolve Issue #94. The changes introduced in this PR will be easier to see once PR #91 is merged in.

3 different instances of the cell component are used in a cluster group. To ensure that all cell components change if someone is optimizing the cell parameters, the design parameters of each cell should be promoted up to the system level (eventually, we would want the ability to promote these up to the "cluster" level in case each cluster has a unique cell design).

Related issue, if one exists

Intended to resolve Issue #94

Also updated the pyproject.toml to include the tests added in PR #92

Impacted areas of the software

  • electrolyzer/components/cell/cell_design_params.py: new file with function get_cell_params_for_model
  • electrolyzer/core/bert.py
    • load_config(): added new boolean attribute identical_cells as a placeholder. This attribute is True if all clusters have identical cells and can be used to determine which level to promote the cell parameters to in the future (if clusters have unique cell designs)
    • create_controller_cluster_connector(): added cell_design_params as an input
    • create_cluster_simulation_block(): added cell_design_params as an input
    • create_components(): updated to call get_cell_params_for_model()

Additional supporting information

Test results, if applicable

@elenya-grant
elenya-grant marked this pull request as ready for review July 29, 2026 22:20
@elenya-grant
elenya-grant merged commit c27be16 into NatLabRockies:develop Jul 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant