Skip to content

fix: stabilize PR comment sessions#58

Merged
DjDeveloperr merged 2 commits into
mainfrom
fix-pr-comment-workflow-crash
May 21, 2026
Merged

fix: stabilize PR comment sessions#58
DjDeveloperr merged 2 commits into
mainfrom
fix-pr-comment-workflow-crash

Conversation

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

@DjDeveloperr DjDeveloperr commented May 20, 2026

Summary

  • Preserve the native daemon recoverable-restart contract in the npm CLI wrapper for simdeck daemon run.
  • Keep daemon metadata pointed at the stable wrapper process via SIMDECK_DAEMON_METADATA_PID, so PR-session lifecycle checks watch the right PID.
  • Keep iOS and Android PR-comment workflows tolerant of the short health gap during a legitimate daemon restart.
  • Fix artifact lookup and status comments so missing/expired artifacts produce an explicit startup failure instead of an immediate misleading ended status.

Root cause

The PR-comment workflows install SimDeck from npm, where simdeck is bin/simdeck.mjs. The native daemon already exits with code 75 for recoverable restarts, but the npm wrapper passed that exit through. The workflow then treated the wrapper PID as dead even though daemon metadata could still point at a separate native process.

Testing

  • npm run test:github-actions
  • npx prettier --check bin/simdeck.mjs actions/run-ios-comment-session/action.yml actions/run-android-comment-session/action.yml scripts/github-actions.test.mjs
  • git diff --check

@DjDeveloperr DjDeveloperr marked this pull request as ready for review May 20, 2026 23:47
@DjDeveloperr DjDeveloperr changed the title fix: harden PR comment sessions against daemon flake fix: stabilize PR comment sessions May 20, 2026
@DjDeveloperr DjDeveloperr merged commit 4edbc15 into main May 21, 2026
7 checks passed
@DjDeveloperr DjDeveloperr deleted the fix-pr-comment-workflow-crash branch May 21, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant