[NathanWalker]

Summary

Extracts facebook::jsi and rnv8::V8Runtime into two standalone, opt-in packages so the core @nativescript/ios and @nativescript/android runtime binaries remain completely free of JSI bloat:

• @nativescript/ios-jsi (packages/ios-jsi):
  • Distributed as a Swift Package (Package.swift) wired via nativescript.config.ts (SPMPackages) with zero CocoaPods required.
  • Provides facebook::jsi and rnv8::V8Runtime for iOS.
  • Exposes NativeScriptJSIRuntime(), tns::GetJSIRuntime(), and Objective-C/Swift JSIRuntime.runtime() / JSIRuntime.runtimePointer() keyed per v8::Isolate::GetCurrent() (supporting both main thread and Worker isolates) without depending on internal NativeScript runtime headers.
• @nativescript/android-jsi (packages/android-jsi):
  • Provides facebook::jsi and rnv8::V8Runtime (libnativescript-jsi.so) for Android.
  • Resolves V8 symbols directly against the loaded libNativeScript.so runtime in the process and keys std::shared_ptr<facebook::jsi::Runtime> per v8::Isolate::GetCurrent().
  • Exposes NativeScriptJSIRuntime(), tns::GetJSIRuntime(), and org.nativescript.jsi.JSIRuntime JNI helpers.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: e937bac4-541e-4dc7-93f2-e9dda4da5202

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ammarahm-ed]

Hello Nathan, i like the enthusiasm here but I believe these should be in a separate repo, not part of the runtimes repo at all.

Runtimes are strictly just Nativescript runtimes and this jsi implementation has a very niche use here and shouldn't be added. Let's keep the runtimes clean and focused on what they are supposed to do. Provide Native APIs in JS.

Even if you still wanted, this should have landed in the v8 runtime repo because it's v8 only AFAIK which is something I am against too. Keep this in a separate repo outside v8 or the runtimes repo.

[NathanWalker]

Do you feel https://github.com/NativeScript/plugins or https://github.com/NativeScript/ui-kit is better place?
They do seem more runtime related like the react-native package itself no? @ammarahm-ed

[ammarahm-ed]

@NathanWalker This repo is the wrong home for it. jsi::Runtime is React Native's abstraction. This repo is the NativeScript runtimes.

If you want this to exist, put it in its own repo and depend on a published runtime version. Then you can move as fast as you like without the runtime holding you back, or the other way round.