Repository navigation
fix(build): give every engine a Tools entry - #35
Merged
Merged
Conversation
build.ps1 runs under `Set-StrictMode -Version Latest`, where reading a missing hashtable key with dot syntax throws. Only hermes defined `Tools`, so the v8, quickjs and jsc framework builds failed at the tool-staging loop after the cargo build succeeded.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
npm releasefailure in run 40044321419: the v8, quickjs and jsc jobs fail, while hermes and classic pass.build.ps1runs underSet-StrictMode -Version Latest, where reading a missing hashtable key with dot syntax throws. The tool-staging loop added with Hermes bytecode precompilation (#33) reads$EngineInfo.Tools, but only thehermesentry defined it. The cargo build succeeds and the failure comes right after it.The fix adds
Tools = @()to the v8, quickjs and jsc entries, matching howDllsis declared for every engine.Verified locally:
template/build.ps1 -Engine quickjsnow runs to "framework staged". In the failing run the hermes job still packedframework/tools/hermesc.exe, so the hermes path is unchanged.