Skip to content

fix(build): give every engine a Tools entry - #35

Merged
triniwiz merged 1 commit into
mainfrom
fix/build-engine-tools
Oct 24, 2026
Merged

triniwiz merged 1 commit into
mainfrom
fix/build-engine-tools

Conversation

@triniwiz

Copy link
Copy Markdown
Member

Fixes the npm release failure in run 40044321419: the v8, quickjs and jsc jobs fail, while hermes and classic pass.

template/build.ps1:169
foreach ($tool in @($EngineInfo.Tools | Where-Object { $_ })) {
The property 'Tools' cannot be found on this object.

build.ps1 runs under Set-StrictMode -Version Latest, where reading a missing hashtable key with dot syntax throws. The tool-staging loop added with Hermes bytecode precompilation (#33) reads $EngineInfo.Tools, but only the hermes entry defined it. The cargo build succeeds and the failure comes right after it.

The fix adds Tools = @() to the v8, quickjs and jsc entries, matching how Dlls is declared for every engine.

Verified locally: template/build.ps1 -Engine quickjs now runs to "framework staged". In the failing run the hermes job still packed framework/tools/hermesc.exe, so the hermes path is unchanged.

build.ps1 runs under `Set-StrictMode -Version Latest`, where reading a missing hashtable key
with dot syntax throws. Only hermes defined `Tools`, so the v8, quickjs and jsc framework
builds failed at the tool-staging loop after the cargo build succeeded.
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 975cf36c-a9e3-460c-b2ae-e46010d5dfbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@triniwiz
triniwiz merged commit af3a904 into main Oct 24, 2026
1 check passed
@triniwiz
triniwiz deleted the fix/build-engine-tools branch October 24, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant