Skip to content

Fix Dart primary constructor compatibility #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fotiDim merged 1 commit into from
Jun 3, 2026
Merged

Fix Dart primary constructor compatibility #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/lib/data/mock_universal_ble.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class MockUniversalBle extends UniversalBlePlatform {
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
}) async {
await Future.delayed(const Duration(milliseconds: 500));
return _serviceValue;
Expand Down
2 changes: 1 addition & 1 deletion lib/src/interfaces/universal_ble_platform_interface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ abstract class UniversalBlePlatform {
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
});

Future<void> writeValue(
Expand Down
4 changes: 2 additions & 2 deletions lib/src/universal_ble.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class UniversalBle {
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
}) async {
return await _bleCommandQueue.queueCommand(
() => _platform.readValue(
Expand Down Expand Up @@ -594,7 +594,7 @@ class UniversalBle {
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
}) {
return read(deviceId, service, characteristic, timeout: timeout);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/src/universal_ble_linux/universal_ble_linux.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ class UniversalBleLinux extends UniversalBlePlatform {
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
}) async {
UniversalLogger.logDebug(
"READ -> $deviceId $service $characteristic",
Expand Down
2 changes: 1 addition & 1 deletion lib/src/universal_ble_pigeon/universal_ble_pigeon_channel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class UniversalBlePigeonChannel extends UniversalBlePlatform
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
}) {
return _executeWithErrorHandling(
() => _channel.readValue(deviceId, service, characteristic),
Expand Down
2 changes: 1 addition & 1 deletion lib/src/universal_ble_web/universal_ble_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ class UniversalBleWeb extends UniversalBlePlatform {
String deviceId,
String service,
String characteristic, {
final Duration? timeout,
Duration? timeout,
}) async {
UniversalLogger.logDebug(
"READ -> $deviceId $service $characteristic",
Expand Down
Loading