Add a title to popups

[micampe]

Looks like the titles were already there from the beginning but always commented out 8109195

[CKolkey]

yea, I thought they looked a bit cheesy, so never shipped it.

[micampe]

yea, I thought they looked a bit cheesy, so never shipped it.

I actually find them very useful, without title I can get lost.

[CKolkey]

tell you what - we can put it behind a config flag

[micampe]

Nice, works for me. Pushed a version with the option, tried to follow existing style/conventions.

[CKolkey]

Looks good to me, thanks :)

[micampe]

Thank you!

Unfortunately I wasn't fast enough to push the fix and the test I added is failing:

@@ -1298,6 +1300,7 @@ function M.validate_config()
     -- Popup
     if validate_type(config.popup, "popup", "table") then
       validate_kind(config.popup.kind, "popup.kind")
+      validate_type(config.popup.show_title, "popup.show_title", "boolean")
     end
 
     if validate_type(config.git_services, "git_services", "table") then

[CKolkey]

Ah, no worries. That what I get for not keeping CI in good working order.