Fix local player's players killed report not resetting each round

src/game/client/CMakeLists.txt

@@ -1575,6 +1575,7 @@ set(UNITY_SOURCE_NEO_SRC_CLIENT
     neo/neo_fixup_glshaders.cpp
     neo/c_neo_bloom_controller.cpp
     neo/neo_killer_damage_info.cpp
+    neo/c_neo_killer_infos.cpp
 )
 
 set_source_files_properties(

src/game/client/hl2mp/c_hl2mp_player.cpp

@@ -872,6 +872,14 @@ void C_HL2MP_Player::PostDataUpdate( DataUpdateType_t updateType )
 	{
 		MoveToLastReceivedPosition( true );
 		ResetLatched();
+#ifdef NEO
+		// NEO NOTE (nullsystem): Respawning doesn't trigger
+		// C_NEO_Player::Spawn/m_bFirstAliveTick without this
+		if (IsLocalPlayer())
+		{
+			static_cast<C_NEO_Player *>(this)->m_bFirstAliveTick = true;
+		}
+#endif
 		m_iSpawnInterpCounterCache = m_iSpawnInterpCounter;
 	}
 

src/game/client/neo/c_neo_killer_infos.cpp

@@ -0,0 +1,10 @@
+#include "c_neo_killer_infos.h"
+
+#include "strtools.h"
+
+void NeoUserIDsLocalKilledClear()
+{
+	g_neoUserIDsLocalKilledSize = 0;
+	V_memset(g_neoUserIDsLocalKilled, 0, sizeof(g_neoUserIDsLocalKilled));
+}
+

src/game/client/neo/c_neo_killer_infos.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "shareddefs.h"
+
 static constexpr const int WEP_NAME_MAXSTRLEN = 32;
 
 struct CNEOKillerInfos
@@ -13,5 +15,10 @@ struct CNEOKillerInfos
 	wchar_t wszKilledWith[WEP_NAME_MAXSTRLEN];
 };
 
-// Global instance of CNEOKillerInfos
+void NeoUserIDsLocalKilledClear();
+
+// Global instance of CNEOKillerInfos and local-player's kill record
 inline CNEOKillerInfos g_neoKillerInfos;
+inline int g_neoUserIDsLocalKilledSize;
+inline int g_neoUserIDsLocalKilled[MAX_PLAYERS_ARRAY_SAFE];
+

src/game/client/neo/c_neo_player.cpp

@@ -479,6 +479,7 @@ C_NEO_Player::C_NEO_Player()
 	m_flTocFactor = 0.15f;
 
 	memset(m_szNeoNameWDupeIdx, 0, sizeof(m_szNeoNameWDupeIdx));
+	if (IsLocalPlayer()) NeoUserIDsLocalKilledClear();
 	m_szNameDupePos = 0;
 }
 
@@ -1207,6 +1208,9 @@ void C_NEO_Player::PreThink( void )
 			CLocalPlayerFilter filter;
 			enginesound->SetPlayerDSP(filter, 0, true);
 
+			NeoUserIDsLocalKilledClear();
+			V_memset(&g_neoKillerInfos, 0, sizeof(CNEOKillerInfos));
+
 			// Reset the cache of other players crosshair data on spawning in
 			if (CHudCrosshair *crosshair = GET_HUDELEMENT(CHudCrosshair))
 			{
@@ -1625,11 +1629,10 @@ void C_NEO_Player::Spawn( void )
 		m_rfAttackersAccumlator.GetForModify(i) = 0.0f;
 		m_rfAttackersHits.GetForModify(i) = 0;
 	}
-	V_memset(m_rfNeoPlayerIdxsKilledByLocal, 0, sizeof(m_rfNeoPlayerIdxsKilledByLocal));
+	if (IsLocalPlayer()) NeoUserIDsLocalKilledClear();
 
 	Weapon_SetZoom(false);
 
-
 	SetViewOffset(VEC_VIEW_NEOSCALE(this));
 
 	auto *localPlayer = C_NEO_Player::GetLocalNEOPlayer();

src/game/client/neo/c_neo_player.h

@@ -263,6 +263,8 @@ class C_NEO_Player : public C_HL2MP_Player
 	unsigned char m_NeoFlags;
 
 private:
+	friend C_HL2MP_Player;
+
 	bool m_bFirstAliveTick;
 	bool m_bFirstDeathTick;
 	bool m_bPreviouslyReloading;
@@ -278,9 +280,6 @@ class C_NEO_Player : public C_HL2MP_Player
 	mutable char m_szNeoNameWDupeIdx[MAX_PLAYER_NAME_LENGTH + 10];
 	mutable int m_szNeoNameLocalDupeIdx;
 
-public:
-	bool m_rfNeoPlayerIdxsKilledByLocal[MAX_PLAYERS_ARRAY_SAFE];
-
 private:
 	C_NEO_Player(const C_NEO_Player &);
 };

src/game/client/neo/ui/neo_hud_deathnotice.cpp

@@ -765,7 +765,8 @@ void CNEOHud_DeathNotice::AddPlayerDeath(IGameEvent* event)
 {
 	// the event should be "player_death"
 	const int killer = engine->GetPlayerForUserID(event->GetInt("attacker"));
-	const int victim = engine->GetPlayerForUserID(event->GetInt("userid"));
+	const int iVictimUserID = event->GetInt("userid");
+	const int victim = engine->GetPlayerForUserID(iVictimUserID);
 	const int assistInt = event->GetInt("assists");
 	const int assist = engine->GetPlayerForUserID(assistInt);
 	const bool hasAssists = assist > 0;
@@ -859,9 +860,24 @@ void CNEOHud_DeathNotice::AddPlayerDeath(IGameEvent* event)
 	deathMsg.bInvolved = killer == GetLocalPlayerIndex() || victim == GetLocalPlayerIndex() || assist == GetLocalPlayerIndex();
 	Assert(victim >= 0 && victim < (MAX_PLAYERS + 1));
 	C_NEO_Player *localPlayer = C_NEO_Player::GetLocalNEOPlayer();
-	if (localPlayer)
+	if (localPlayer
+			&& killer == localPlayer->entindex()
+			&& g_neoUserIDsLocalKilledSize < MAX_PLAYERS_ARRAY_SAFE)
 	{
-		localPlayer->m_rfNeoPlayerIdxsKilledByLocal[victim] = (killer == localPlayer->entindex());
+		// Sanity check it's not there already just in-case
+		bool bVictimUserIDExists = false;
+		for (int i = 0; i < g_neoUserIDsLocalKilledSize; ++i)
+		{
+			if (iVictimUserID == g_neoUserIDsLocalKilled[i])
+			{
+				bVictimUserIDExists = true;
+				break;
+			}
+		}
+		if (false == bVictimUserIDExists)
+		{
+			g_neoUserIDsLocalKilled[g_neoUserIDsLocalKilledSize++] = iVictimUserID;
+		}
 	}
 
 	SetDeathNoticeItemDimensions(&deathMsg);

src/game/client/neo/ui/neo_hud_killer_info.cpp

@@ -63,13 +63,6 @@ void CNEOHud_KillerInfo::resetHUDState()
 
 void CNEOHud_KillerInfo::UpdateStateForNeoHudElementDraw()
 {
-	const bool bIsPreRoundFreeze = (NEORules()->GetRoundStatus() == NeoRoundStatus::PreRoundFreeze);
-	if (bIsPreRoundFreeze && false == m_preRoundFreezeCleared)
-	{
-		resetHUDState();
-	}
-	m_preRoundFreezeCleared = bIsPreRoundFreeze;
-
 	// If to show or not
 	const C_NEO_Player *pLocalPlayer = C_NEO_Player::GetLocalNEOPlayer();
 	m_bPlayerShownHud = pLocalPlayer
@@ -91,8 +84,13 @@ void CNEOHud_KillerInfo::UpdateStateForNeoHudElementDraw()
 
 void CNEOHud_KillerInfo::DrawNeoHudElement()
 {
+	if (!ShouldDraw() || !m_bPlayerShownHud)
+	{
+		return;
+	}
+
 	const C_NEO_Player *pLocalPlayer = C_NEO_Player::GetLocalNEOPlayer();
-	if (!ShouldDraw() || !m_bPlayerShownHud || !pLocalPlayer)
+	if (!pLocalPlayer)
 	{
 		return;
 	}

src/game/client/neo/ui/neo_hud_killer_info.h

@@ -29,6 +29,5 @@ class CNEOHud_KillerInfo : public CNEOHud_ChildElement, public CHudElement, publ
 	vgui::HFont m_hFontNormal;
 	vgui::HFont m_hFontTitle;
 	CAvatarImage m_avatar;
-	bool m_preRoundFreezeCleared = false;
 	bool m_bPlayerShownHud = false;
 };

src/game/client/neo/ui/neo_scoreboard.cpp

@@ -392,7 +392,15 @@ void CNEOScoreBoard::Update()
 			pPlayerInfo->iTakenDmgs = pLocalPlayer->GetAttackersScores(pNeoPlayer->entindex());
 			pPlayerInfo->iTakenHits = pLocalPlayer->GetAttackerHits(pNeoPlayer->entindex());
 			pPlayerInfo->bKilledYou = (pNeoPlayer->entindex() == g_neoKillerInfos.iEntIndex);
-			pPlayerInfo->bYouKilled = pLocalPlayer->m_rfNeoPlayerIdxsKilledByLocal[pNeoPlayer->entindex()];
+			pPlayerInfo->bYouKilled = false;
+			for (int i = 0; i < g_neoUserIDsLocalKilledSize; ++i)
+			{
+				if (g_neoUserIDsLocalKilled[i] == pPlayerInfo->iUserID)
+				{
+					pPlayerInfo->bYouKilled = true;
+					break;
+				}
+			}
 		}
 		else
 		{

src/game/client/neo/ui/neo_scoreboard.h

@@ -98,7 +98,7 @@ class CNEOScoreBoard : public vgui::Panel, public IViewPortPanel, public CGameEv
 
 	int	m_HLTVSpectators = 0;
 	int m_iTotalPlayers = 0;
-	CNEOScoreBoardPlayer m_playersInfo[MAX_PLAYERS + 1] = {};
+	CNEOScoreBoardPlayer m_playersInfo[MAX_PLAYERS_ARRAY_SAFE] = {};
 	CNEOScoreBoardPlayer m_playerPopup = {};
 
 	wchar_t m_wszHostname[128] = {};