Count entities#64
Open
hoffmanick wants to merge 4 commits into
Open
Conversation
count() method on site or sites object that counts, for a given level ("sites","collunits", or "datasets") the number of the level in the object. Added a test on its logic
helps me run the tests on R obects without crashing the API
I added in a count() method with argument 'level' (default level="sites" but can be set to "collunits" or "datasets") which counts sites or site objects. I also added in a test to test_sites to check that count() works as expected. And I updated all the other tests to the current version in dev to hopefully pass the tests without overloading API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added in a method on sites and site objects that counts the number of sites, collectionunits, or datasets in the object. The argument level is set to "sites" as default but can take "collunits" or "datasets." I also added in a test to test_sites to make sure the test works appropriately, and I replaced all the other tests in this branch with the current version from dev to hopefully pass the tests without overloading API.