Bugfix/samples#65
Open
hoffmanick wants to merge 6 commits into
Open
Conversation
1. changed test_get_downloads to remove Rhode Island from test gpids. Some messed up data in RI. 2. Added in notes to collunit builder in parse_sites
Adding in a chronname param to samples to enable selection of the particular chronology you want
Updated tests to the version in count_entities but commented out the count() method test in test_sites because the count() method doesn't exist in this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the branch where I added in an argument chronname to samples that takes the chronology name which the user wants to use for assigning sample ages to samples. I also updated tests to the version in dev to make testing easier to pass.