Skip to content

bugfix/CSTACKEX-143: Second VM creation creates a dummy running VM wi… #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush5netapp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix/CSTACKEX-143: Second VM creation creates a dummy running VM wi… #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool, Map<S
if (result != null) {
if (isNonFatalLogin(result)) {
logger.debug("iSCSI login returned benign message for {}@{}:{}: {}", iqn, host, port, result);
// Session already exists — a newly mapped LUN won't be visible until
Copy link
Copy Markdown

@rajiv-jain-netapp rajiv-jain-netapp Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have it updated with elaborated details in out design document.

// the kernel's next periodic SCSI scan (~30-60s).
Copy link
Copy Markdown

@suryag1201 suryag1201 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in comment for iSCSI

Script rescanCmd = new Script(true, "iscsiadm", 0, logger);
rescanCmd.add("-m", "session");
rescanCmd.add("--rescan");
String rescanResult = rescanCmd.execute();
if (rescanResult != null) {
logger.warn("iSCSI session rescan returned: {}", rescanResult);
Copy link
Copy Markdown

@suryag1201 suryag1201 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it is warn?

} else {
logger.debug("iSCSI session rescan completed successfully for {}@{}:{}", iqn, host, port);
}
} else {
logger.debug("Failed to log in to iSCSI target " + volumeUuid + ": " + result);
System.out.println("Failed to log in to iSCSI target " + volumeUuid);
Expand Down
Loading