NSOL-5942: saving base config before configuring dataset manager

Author: sushma-m1

netapp_dataops_traditional/netapp_dataops/config/dataset_manager.py

@@ -198,12 +198,39 @@ def _setup_existing_root_volume(self, config: DatasetManagerConfig) -> None:
         self._handle_root_volume_mounting(root_volume_name, root_mountpoint)
 
     def _setup_new_root_volume(self, config: DatasetManagerConfig) -> None:
-        """Perform operations for new root volume after config is saved."""
+        """Perform operations for new root volume after config is saved.
+        
+        Note: This method assumes the base ONTAP configuration has already been
+        saved to disk before being called, as it needs to access ONTAP APIs.
+        """
         root_volume_name = config.root_volume_name
         root_mountpoint = config.root_mountpoint
 
         logger.info(f"\n  Setting up new Dataset Manager root volume '{root_volume_name}'...")
 
+        # Verify we can connect to ONTAP before proceeding
+        try:
+            from ..traditional.core import _retrieve_config
+            from ..traditional.exceptions import InvalidConfigError
+            
+            # Try to retrieve config to verify it exists and is valid
+            try:
+                ontap_config = _retrieve_config(print_output=False)
+                # Verify we have the minimum required fields
+                if not all(k in ontap_config for k in ['hostname', 'svm', 'dataLif']):
+                    raise InvalidConfigError("Missing required ONTAP configuration fields")
+            except (InvalidConfigError, FileNotFoundError, KeyError) as e:
+                logger.info(f"  Note: Cannot create root volume - ONTAP configuration not available yet.")
+                logger.info(f"  Dataset Manager configuration has been saved.")
+                logger.info(f"  The root volume will be created when you first use Dataset Manager,")
+                logger.info(f"  or you can create it manually: netapp_dataops_cli.py create volume -n {root_volume_name} -s 1GB")
+                return
+        except Exception as e:
+            logger.info(f"  Note: Cannot validate ONTAP connection: {e}")
+            logger.info(f"  Dataset Manager configuration has been saved.")
+            logger.info(f"  Please create the root volume manually or reconfigure later.")
+            return
+        
         while True:  # Loop for retrying with different names if needed
             try:
                 # Check if volume already exists

netapp_dataops_traditional/netapp_dataops/config/manager.py

@@ -126,6 +126,18 @@ def create_interactive_config(self) -> NetAppDataOpsConfig:
             dataset_manager_config = None
             if PromptUtils.prompt_yes_no("Do you intend to use the toolkit's Dataset Manager functionality?"):
                 logger.info("\nDataset Manager Configuration:")
+                
+                # IMPORTANT: Save base ONTAP config to disk BEFORE Dataset Manager setup
+                # This allows Dataset Manager to connect to ONTAP and create volumes
+                base_config = NetAppDataOpsConfig(
+                    ontap=ontap_config,
+                    s3=s3_config,
+                    cloud_sync=cloud_sync_config,
+                    dataset_manager=None  # Will be added after setup
+                )
+                self.save_config(base_config)
+                
+                # Now Dataset Manager can connect to ONTAP using the saved config
                 dataset_manager_configurator = DatasetManagerConfigurator()
                 dataset_manager_config = dataset_manager_configurator.configure_dataset_manager()