Add a metric to capture write enqueue latency#193
Open
jasonk000 wants to merge 2 commits into
Open
Conversation
This captures from when the caller tries to send a request until the request is finally sent on the wire, primarily so we can see when the enqueue time is increasing (a signal for pressure on the IO loop).
akhaku
approved these changes
May 15, 2026
akhaku
left a comment
akhaku
left a comment
There was a problem hiding this comment.
technically not sent on the wire but passed to the non-blocking socket, right?
Generally LGTM
| if (wc <= 0L || wc < operationAttachedNs) return; | ||
| loopEnqueueToWriteLatency.record(wc - operationAttachedNs, TimeUnit.NANOSECONDS); | ||
| } catch (Throwable t) { | ||
| if (log.isDebugEnabled()) log.debug("recordLoopEnqueueToWriteLatency failed", t); |
There was a problem hiding this comment.
we don't really need the isDebugEnabled check here right since the expression in log.debug is cheap
Member
Author
There was a problem hiding this comment.
Yes. Updated the comments to make that more clear, and dropped that catch there since the onyl thing we have is a record() call. -> a6d34e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This captures from when the caller tries to send a request until the request is finally sent on the wire, primarily so we can see when the enqueue time is increasing (a signal for pressure on the IO loop).