feat(ipsec): convert DPD to combobox#768
Merged
Merged
Conversation
gsanchietti
force-pushed
the
feat/ipsec-dpd-combobox
branch
from
09a24f8 to
fafd112
Compare
gsanchietti
force-pushed
the
feat/ipsec-dpd-combobox
branch
from
fafd112 to
fa8abb1
Compare
Tbaile
requested changes
May 15, 2026
Collaborator
Tbaile
left a comment
Tbaile
left a comment
There was a problem hiding this comment.
Why the need for a lib for a single method that is being used only on the tunnel drawer?
Changes: - expose all possibile values for dpd action - add tooltip to explain the option values Assysted-by: Copilot:GPT5.4
gsanchietti
force-pushed
the
feat/ipsec-dpd-combobox
branch
from
fa8abb1 to
65980b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert DPD radio to NeCombobox with options clear/trap/restart.
Fixes: NethServer/nethsecurity#1298
Related PR (no required for the UI): NethServer/nethsecurity#1676
Screenshot:
Available options:
