refactor: centralize module testing#98
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/NethServer/ns8-imapsync/sessions/00434d5a-2625-4ff3-8747-eb837cea25f3 Co-authored-by: andre8244 <4612169+andre8244@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor: centralize module testing
refactor: centralize module testing
May 4, 2026
e4da26c to
e0afeec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Migrates to the NS8 standard testing infrastructure via
NethServer/ns8-github-actionsreusable workflows, replacing the bespoketest-module.sh-based setup.Changes
.github/workflows/test-module.yml— replaced with reusable workflow call (ns8-github-actions/.github/workflows/test-module.yml@v1),ui_tests_strategy: alwaystests/15_ui.robot— new UI screenshot test; runs after install (10_install_mail.robot) and before functional tests (20_imapsync.robot), using the${MID}global variable set during installtest-module.sh— deletedtests/pythonreq.txt— deleted.gitignore— addedtests/outputs/README.md—## Testingsection replaced with## Running tests locallypointing to the ns8-github-actions docsRef: NethServer/dev#7281
Original prompt
refactor: centralize module testing
Ref:
Please make the following changes:
1. Replace
.github/workflows/test-module.ymlReplace the entire content of
.github/workflows/test-module.ymlwith:(Note:
ui_tests_strategy: alwaysmust be at line 19.)2. Update
.gitignoreAdd
tests/outputs/to.gitignoreif it's not already present.3. Update
README.mdReplace the existing
## Testingsection (currently contains references totest-module.shand Robot Framework) with the following section. Use## Running tests locallyas the new header:4. Delete
test-module.shDelete the file
test-module.shfrom the root of the repository.5. Delete
tests/pythonreq.txtDelete the file
tests/pythonreq.txt.6. Add UI tests robot file
The file
ui/src/App.vueexists, so UI tests must be added.The tests directory has multiple robot files (excluding
__init__.robot):tests/10_install_mail.robot— installs the module (containsadd-module), usesSet Global Variable ${MID} ${output.module_id}tests/20_imapsync.robot— tests imapsynctests/90_uninstall.robot— uninstallsRobot files use single underscore naming (e.g.
10_install_mail.robot).Create a new file
tests/15_ui.robotfor UI tests. The module ID variable is${MID}(set as a Global Variable in10_install_mail.robot).The content of
tests/15_ui.robotshould be:Commit message
Use
refactor: centralize module testingas the commit message.The following is the prior conversation context from the user's chat exploration (may be truncated):
User: Create a PR for the following repositories:
PR title and commit message are "refactor: centralize module testing"
PR description is the following:
Ref:
The changes to perform are the following:
ui_tests_strategy: alwaysat line 19tests/outputs/## Running tests locallyas headerui/src/App.vueexists, then add the robot file for ui tests by doing the following. Inside the tests directory, check how many robots file are present (excluding__init__.robot):__init__.robot) and it contains a test with "Execute Command ...This pull request was created from Copilot chat.