Skip to content

Improve status check and error handling in wait-startup script #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephdl merged 3 commits into from
May 6, 2026
Merged

Improve status check and error handling in wait-startup script #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0254120
fix(wait-startup): improve status check and error handling
stephdl May 4, 2026
8d35926
fix(wait-startup): improve error message for startup timeout
stephdl May 4, 2026
5491343
fix(wait-startup): centralize exit code messages for improved readabi…
stephdl May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions imageroot/bin/wait-startup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#

import sys
import json
import time
import subprocess

Expand All @@ -16,16 +15,23 @@ def occ(args):
return (p.returncode, p.stdout)

# wait after nextcloud-app is ready
exit_code_messages = {1: "maintenance mode enabled", 2: "needs DB upgrade"}
max_tries = 60
i = 0
last_ret = None
while i < max_tries:
i = i+1
try:
ret, out = occ(["status", "--output", "json"])
status = json.loads(out)
if status["installed"]:
ret, out = occ(["status", "-e"])
last_ret = ret
if ret == 0:
break
print(f"wait-startup: waiting for nextcloud-app ({i})", file=sys.stderr)
time.sleep(1)
status_msg = exit_code_messages.get(ret, "not ready")
print(f"wait-startup: waiting for nextcloud-app ({i}): occ status exit code={ret} ({status_msg})", file=sys.stderr)
except Exception as e:
continue
print(f"wait-startup: exception ({i}): {e}", file=sys.stderr)
time.sleep(1)
else:
status_msg = exit_code_messages.get(last_ret, "not ready")
print(f"wait-startup: Nextcloud did not become ready in time (last status: {status_msg})", file=sys.stderr)
sys.exit(1)
Loading