Conversation
anchu-bright
changed the title
derevnjuk
enabled auto-merge (squash)
July 8, 2026 11:27
anchu-bright
changed the title
derevnjuk
reviewed
Jul 8, 2026
derevnjuk
left a comment
derevnjuk
left a comment
Member
There was a problem hiding this comment.
LGTM, seems like are correct and technically accurate, but there are a few minors
There was a problem hiding this comment.
Pull request overview
This PR adds Authenticode code signing for Windows release artifacts by integrating DigiCert KeyLocker (Software Trust Manager) into the deploy workflow, and updates the Windows signing script to sign arbitrary files by certificate thumbprint and verify the result.
Changes:
- Update
tools/scripts/sign-windows.ps1to sign a provided file path usingsigntool /sha1+ RFC3161 timestamping, then verify the signature. - Extend
.github/workflows/deploy.ymlto prepare DigiCert KeyLocker env vars, install DigiCert tooling, sync the cert into the Windows store, and sign both the.exeand.msibefore computing checksums.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/scripts/sign-windows.ps1 | Reworked signing script to sign by SHA1 thumbprint and verify signatures. |
| .github/workflows/deploy.yml | Adds Windows-only DigiCert KeyLocker setup + signing steps for release artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
derevnjuk
approved these changes
Jul 14, 2026
derevnjuk
disabled auto-merge
July 14, 2026 13:11
derevnjuk
enabled auto-merge (squash)
July 14, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Authenticode code signing for the Windows release artifacts using
DigiCert KeyLocker (Software Trust Manager) cloud signing.
In the deploy workflow's generate-binary job (Windows target):
SM_* environment for the DigiCert tooling.
digicert/code-signing-software-trust-action, then run
smctl windows certsyncto sync the code signing certificate intothe local certificate store.
the installer is signed, then sign bright-cli.msi after it is built.
Checksums are computed afterwards, so they cover the signed files.
Rewrite tools/scripts/sign-windows.ps1 to sign a given file by
certificate SHA1 thumbprint (signtool /sha1 with a DigiCert RFC 3161
timestamp) and verify the result. Signing is skipped gracefully when
the SM_* secrets are absent, so local and fork builds still succeed.
Requires the SM_HOST, SM_API_KEY, SM_CLIENT_CERT_FILE_B64,
SM_CLIENT_CERT_PASSWORD and SM_CODE_SIGNING_CERT_SHA1_HASH secrets.