perf(tauri): native desktop event transport with fast assistant streaming#242
perf(tauri): native desktop event transport with fast assistant streaming#242pascalandr wants to merge 2 commits intoNeuralNomadsAI:devfrom
Conversation
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/23398482721 Artifacts expire in 7 days. |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/23398502150 Artifacts expire in 7 days. |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/23399446411 Artifacts expire in 7 days. |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/23401824896 Artifacts expire in 7 days.
|
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/23402541285 Artifacts expire in 7 days. |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/23410012218 Artifacts expire in 7 days.
|
5f572c2 to
4448dd0
Compare
2e5cc4f to
a4cafa6
Compare
fix(tauri): stop desktop event transport on window close
ee22571 to
74ec719
Compare
Minimal UI changes for the dual-lane streaming pipeline: - active stream target tracking in App.tsx for Tauri transport - delta coalescing and assistant stream fast-path handling - markdown render throttling and cache improvements during streaming - virtual follow list scroll coalescing - optimistic send/idle handling aligned with the streaming path
74ec719 to
302e87f
Compare
|
I’d be happy to get a critical review on whether this direction makes sense upstream. |
|
Hey @pascalandr , How does this Tauri specific change effect electron and server UI? |
|
I want you to perform the gatekeeper checks for latest PR state check for regressions |
Only commit 1 is Tauri-specific. Commit 2 is intentionally cross-host: it optimizes how streaming updates are applied/rendered in the UI, so it should benefits Tauri, Electron, and the browser path alike. |
|
Am I correct in understanding that each platform will be using their native EventSource path? |
|
In this PR:
So only the Tauri transport changes here. The UI-side streaming optimizations are host-agnostic and sit below that transport choice. |
|
@pascalandr - I am sure this works well but the problem is I don't have experience with Rust / Tauri . I am more Java / Node person and the Tauri app is 100% maintained by AI and community. The only reason it came in because people wanted it so AI made it. I can't maintain Tauri only features as I can't code review them and EventSource being a core part any changes on it I will be totally reliant on AI or community for it.
Would you help me decide these please? |
|
I see but TBH, the Rust/Tauri transport is the part I cared about most, because I use the Tauri client all day long. |
|
I want you to perform the gatekeeper checks for latest PR state check for regressions
|
|
I reviewed the latest PR state as a gatekeeper review. My understanding of the request: evaluate the current PR for regressions, better implementation options, and specifically call out any knock-on effects on Electron and the server/browser UI discussed in this thread. Findings:
Knock-on effects by host:
Better implementation direction:
Validation notes:
Gatekeeper verdict: not merge-ready. Both findings above are blocking regressions, and one of them hits Electron/server directly. -- |
As of now, I want to keep native ( Tauri / Electron ) features to the bare minimum as my current process is to implement features in web and server and expect them to run on both Electron / Tauri without any changes. This helps me a lot in ways
I will need some time to work out what needs to be done for cases like this. I hope you understand. |
|
When you says not have to test multiple "platforms" do you mean Tauri / Electron or Windows/linux/Macos ? |
Summary
Commit 1 — \perf(tauri): modularize native desktop event transport\
Commit 2 — \perf(ui): add fast assistant streaming render path\
Validation