ci: fix 504 Electron download timeout and upgrade to Node 22#149
Merged
Conversation
…here not needed, cache electron binary in e2e job Co-authored-by: Cursor <cursoragent@cursor.com>
…e binary Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All three failing checks hit the same root cause:
pm ci\ triggers Electron's postinstall script which downloads a ~100 MB binary from GitHub releases. That request times out with a 504 Gateway Timeout.
Additionally, @electron/notarize, @electron/rebuild, and
ode-abi\ all require >=22.12.0\ but every job was running Node 20.
Changes
*\ci.yml*
*\security.yml*
pm install\ to
pm ci\ for deterministic installs
*
elease.yml*