Add event vectordata types#301
Open
oruebel wants to merge 11 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds schema/codegen and C++ support for the new NWB event timing VectorData column types (TimestampVectorData, DurationVectorData), and updates DynamicTable to support reading/adding derived VectorData column types—enabling future EventsTable work.
Changes:
- Added
CORE::TimestampVectorDataandCORE::DurationVectorDataimplementations plus unit tests. - Extended
DynamicTablewith a newaddColumn(VectorData)overload and updatedreadColumntyping to supportVectorDatasubclasses. - Updated
resources/utils(codegen + packaging) and documentation (CHANGELOG.md) to reflect the new types and generation behavior.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/nwb/event/TimestampVectorData.hpp |
New event timestamp column type interface + read/record accessors |
src/nwb/event/TimestampVectorData.cpp |
Timestamp column initialization (unit/resolution attrs + VectorData init) |
src/nwb/event/DurationVectorData.hpp |
New event duration column type interface + read/record accessors |
src/nwb/event/DurationVectorData.cpp |
Duration column initialization logic |
src/nwb/hdmf/table/DynamicTable.hpp |
readColumn trait-based return type support for VectorData subclasses |
src/nwb/hdmf/table/DynamicTable.cpp |
New addColumn(VectorData) overload to register pre-written columns |
tests/testTimestampVectorData.cpp |
New unit tests for TimestampVectorData read/write/registry behavior |
tests/testDurationVectorData.cpp |
New unit tests for DurationVectorData read/write/registry behavior |
tests/testDynamicTable.cpp |
New test ensuring derived VectorData columns can be added and read back |
tests/CMakeLists.txt |
Registers new unit test sources in the test target |
resources/utils/schematype_to_aqnwb.py |
Codegen updates (IO weak_ptr/getIO usage, namespace fixes, formatting) |
resources/utils/aqnwb_utils.py |
Raises script requires-python to 3.10 |
resources/utils/generate_spec_files.py |
Raises script requires-python to 3.10 |
resources/utils/pyproject.toml |
Bumps utils version and requires-python to 3.10 |
CMakeLists.txt |
Adds new event source files to the library build |
CHANGELOG.md |
Documents new types + DynamicTable updates and codegen changes |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #299
schematype_to_aqnwb.pyto facilitate generation the new typesresources/utilsto ensure use of the latest versions of PyNWB with uvgetIOinstead of the previousm_ioshared pointerTimestampVectorDataandDurationVectorDatatypes:nwb/event/TimestampVectorData.hpp/cppnwb/event/DurationVectorData.hpp/cppTimestampVectorDataDurationVectorDataDynamicTableproperly supports the new column types:DynamicTable.readColumnusing type traits to to support reading of both: i) VectorData columns with a specific data type and ii) columns that are a subtype of VectorData (e.g.,TimestampVectorDataandDurationVectorData)DyanmicTable.addColumnto allow adding of fully configured VectorData columns and derived column typesTimestampVectorDataandDurationVectorDatacan be added viaDynamicTable.addColumnand read back viaDynamicTable.readColumn