Add EventTable type#304
Open
oruebel wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #285
Add support for
EventsTableEventTabletypeEventTabletypeevents/group and addedNWBFile::createEventsTableconvenience functionEnhance
DynamicTableto improve support for use during acquisitionDynamicTableso it creates and initializes itsElementIdentifiersidcolumn internally duringinitialize(). This is to ensure theElementIdentifiersare always create before we start the recording. CallingDynamicTable::setRowIDs()previously required creation ofElementIdentifiersbut may be called later during recording. As part of this change,setRowIDs()now takes only the row ID values and writes them directly to the table's built-inidcolumn instead of accepting a separateElementIdentifiersobject. In practice this aligns the API with the intended usage, since callers should have always used the table's owniddataset. (@oruebel, #302)DynamicTablecolumn-name management to be immediate and table-driven.addColumnName()now flushes new column names to the file as columns are added,setColNames()is now restricted to reordering the existing set of columns (it no longer acts as a general overwrite mechanism), andfinalize()no longer writes thecolnamesattribute because column-name updates are persisted when they occur. This ensures that thecolnamesattribute is always consistent with the actual columns in the table and helps avoid creation of invalid files. (@oruebel, #304)Other
TimestampVectorDataandDurationVectorData; e.g, bad namespace and inconsistent ordering of parameters in initialize