refactor: improve type safety across core modules by replacing any wi…

eslint.config.mjs

@@ -19,7 +19,7 @@ export default [
     },
     rules: {
       ...tseslint.configs.recommended.rules,
-      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-explicit-any': 'error',
       '@typescript-eslint/no-require-imports': 'off',
       '@typescript-eslint/no-unused-vars': 'off',
       '@typescript-eslint/no-unsafe-function-type': 'off',

prisma/schema.prisma

@@ -40,6 +40,7 @@ enum AgentAction {
   REBALANCE
   ANALYZE
   ALERT
+  SCAN
   CLAIM_YIELD
 }
 
@@ -95,16 +96,17 @@ model Session {
 }
 
 model AdminApiKey {
-  id        String    @id @default(uuid())
-  name      String    @unique
-  role      String
-  scopes    String[]
-  hash      String
-  expiresAt DateTime?
-  revokedAt DateTime?
-  createdAt DateTime  @default(now())
-  updatedAt DateTime  @updatedAt
-  lastUsedAt DateTime?
+  id          String    @id @default(uuid())
+  name        String    @unique
+  role        String
+  scopes      String[]
+  hash        String
+  tokenPrefix String?
+  expiresAt   DateTime?
+  revokedAt   DateTime?
+  createdAt   DateTime  @default(now())
+  updatedAt   DateTime  @updatedAt
+  lastUsedAt  DateTime?
 
   auditLogs AdminAuditLog[]
 

src/agent/loop.ts

@@ -110,7 +110,7 @@ async function rebalanceCheckJob(): Promise<void> {
       for (const [protocol, protocolPositions] of byProtocol.entries()) {
         const result = await executeRebalanceIfNeeded(
           protocol,
-          protocolPositions.map((p: any) => ({
+          protocolPositions.map((p) => ({
             id: p.id,
             amount: p.currentValue.toString(),
           })),

src/agent/router.ts

@@ -4,6 +4,7 @@
 
 import { logger } from '../utils/logger';
 import { getCorrelationId } from '../utils/correlation';
+import type { AgentAction, AgentStatus } from '@prisma/client';
 import { ProtocolComparison, RebalanceDetails, RebalanceThresholds } from './types';
 import { scanAllProtocols, getCurrentOnChainApy } from './scanner';
 import { triggerRebalance as submitRebalance } from '../stellar/contract';
@@ -178,7 +179,7 @@ export async function triggerRebalance(
             network: representativePosition.user.network,
             protocolName: toProtocol,
             memo: `Agent rebalance from ${fromProtocol} to ${toProtocol}`,
-          } as any,
+          },
         });
       } else {
         logger.warn('No position found to persist rebalance transaction', {
@@ -307,8 +308,8 @@ export async function executeRebalanceIfNeeded(
  *   a null userId so it is distinguishable from user-level actions.
  */
 export async function logAgentAction(
-  action: string,
-  status: 'SUCCESS' | 'FAILED' | 'SKIPPED',
+  action: AgentAction,
+  status: AgentStatus,
   data?: Record<string, unknown>,
   userId?: string,
   positionId?: string,
@@ -327,8 +328,8 @@ export async function logAgentAction(
       data: {
         userId: userId ?? null,
         positionId: positionId ?? null,
-        action: action as any,
-        status: status as any,
+        action,
+        status,
         inputData: inputWithCorrelation ? JSON.stringify(inputWithCorrelation) : data?.input ? JSON.stringify(data.input) : undefined,
         outputData: data?.output ? JSON.stringify(data.output) : undefined,
         reasoning: data?.reasoning as string | undefined,

src/agent/scanner.ts

@@ -2,6 +2,7 @@
  * Scanner - Fetches real APY rates from Stellar yield protocols
  */
 
+import { Network } from '@prisma/client';
 import { logger } from '../utils/logger';
 import { YieldProtocol, ProtocolRate } from './types';
 import db from '../db';
@@ -40,13 +41,12 @@ async function fetchBlendApy(): Promise<YieldProtocol | null> {
 
     const poolId = process.env.BLEND_POOL_ID || 'GBUQWP3BOUZX34PISXEAMBNIZJLNCLVNX77MHAHVXHVVB4CMYAOK6BAC';
 
-    const data = await fetchWithRetry(
+    const data = await fetchWithRetry<{ reserves?: Array<{ asset?: { code?: string; symbol?: string }; supplyApy?: string; totalSupply?: string }> }>(
       `${network}/api/v1/pool/${poolId}`,
       { timeout: 5000, retries: 3 }
     );
 
-    // Extract USDC reserve APY and TVL from response
-    const reserve = data?.reserves?.find((r: any) =>
+    const reserve = data?.reserves?.find((r) =>
       r.asset?.code === 'USDC' || r.asset?.symbol === 'USDC'
     );
 
@@ -87,7 +87,7 @@ async function fetchStellarDexApy(): Promise<YieldProtocol | null> {
     const horizonUrl = process.env.HORIZON_URL || 'https://horizon.stellar.org';
     const usdcIssuer = process.env.USDC_ISSUER || 'GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN';
 
-    const data = await fetchWithRetry(
+    const data = await fetchWithRetry<{ _embedded?: { records?: Array<{ total_shares?: string; fee_bp?: string }> } }>(
       `${horizonUrl}/liquidity_pools?reserves=${ASSET_SYMBOL}:${usdcIssuer}&limit=10&order=desc`,
       { timeout: 5000, retries: 3 }
     );
@@ -134,16 +134,16 @@ async function fetchLumaApy(): Promise<YieldProtocol | null> {
   try {
     const lumaUrl = process.env.LUMA_API_URL || 'https://api.luma.finance';
 
-    const data = await fetchWithRetry(
+    const data = await fetchWithRetry<{ rates?: Array<{ asset?: string; symbol?: string; apy?: string; tvl?: string }> }>(
       `${lumaUrl}/v1/rates?asset=${ASSET_SYMBOL}`,
       { timeout: 5000, retries: 3 }
     );
 
-    const rate = data?.rates?.find((r: any) =>
+    const rate = data?.rates?.find((r) =>
       r.asset === ASSET_SYMBOL || r.symbol === ASSET_SYMBOL
     );
 
-    if (!rate) throw new Error('USDC rate not found in Luma response');
+    if (!rate?.apy) throw new Error('USDC rate not found in Luma response');
 
     const apyRate = parseFloat(rate.apy) * 100;
     const tvl = rate.tvl ? parseFloat(rate.tvl) : undefined;
@@ -209,15 +209,16 @@ export async function scanAllProtocols(): Promise<YieldProtocol[]> {
   return filtered;
 }
 
-function normalizeNetwork(): string {
+function normalizeNetwork(): Network {
   const network = process.env.STELLAR_NETWORK?.toLowerCase();
-  const validNetworks = ['mainnet', 'testnet', 'futurenet'];
-  if (!network || !validNetworks.includes(network)) {
+  const validNetworks: Network[] = ['MAINNET', 'TESTNET', 'FUTURENET'];
+  const upper = network?.toUpperCase() as Network | undefined;
+  if (!upper || !validNetworks.includes(upper)) {
     throw new Error(
       `Invalid STELLAR_NETWORK: "${process.env.STELLAR_NETWORK}". Must be one of: ${validNetworks.join(', ')}`
     );
   }
-  return network.toUpperCase();
+  return upper;
 }
 
 /**
@@ -231,10 +232,9 @@ async function saveProtocolRates(protocols: YieldProtocol[]): Promise<void> {
         data: {
           protocolName: protocol.name,
           assetSymbol: protocol.assetSymbol,
-          supplyApy: protocol.apy as any,
-          tvl: protocol.tvl === undefined ? undefined : (protocol.tvl as any),
-          network: networkLabel as any,
-          rawResponse: JSON.stringify({ fetchedAt: new Date(), source: protocol.name }),
+          supplyApy: protocol.apy,
+          tvl: protocol.tvl === undefined ? undefined : protocol.tvl,
+          network: networkLabel,
         },
       });
     }

src/agent/snapshotter.ts

@@ -35,7 +35,7 @@ export async function captureAllUserBalances(): Promise<void> {
 
     // CRITICAL FIX: Use batch insert (createMany) instead of individual awaits
     // This scales much better as user base grows
-    const snapshotData = positions.map((pos: any) => {
+    const snapshotData = positions.map((pos) => {
       const yearsActive = calculateYearsActive(pos.openedAt);
       const apy = calculateApy(
         pos.depositedAmount.toNumber(),
@@ -46,7 +46,7 @@ export async function captureAllUserBalances(): Promise<void> {
       return {
         positionId: pos.id,
         // Coerce computed APY (number) into Prisma Decimal field.
-        apy: apy as any,
+        apy,
         yieldAmount: pos.yieldEarned,
         principalAmount: pos.depositedAmount,
       };
@@ -122,7 +122,7 @@ export async function getPositionHistory(
       },
     });
 
-    return snapshots.map((snapshot: any) => ({
+    return snapshots.map((snapshot) => ({
       userId: snapshot.position.userId,
       walletAddress: snapshot.position.user.walletAddress,
       positionId,

src/config/env.ts

@@ -113,7 +113,7 @@ function validateAllRequiredEnvVars(): void {
   // ── 10. NODE_ENV: must be one of the known deployment environments ────────
   const nodeEnv = process.env.NODE_ENV
   const validNodeEnvs = ['development', 'staging', 'production', 'test'] as const
-  if (nodeEnv && !validNodeEnvs.includes(nodeEnv as any)) {
+  if (nodeEnv && !(validNodeEnvs as readonly string[]).includes(nodeEnv)) {
     errors.push(
       `NODE_ENV is invalid: "${nodeEnv}". Must be one of: ${validNodeEnvs.join(' | ')}`
     )
@@ -137,7 +137,7 @@ function validateStellarNetwork(network: string): 'testnet' | 'mainnet' | 'futur
   const validNetworks = ['testnet', 'mainnet', 'futurenet'] as const
   const lowerNetwork = network.toLowerCase()
 
-  if (!validNetworks.includes(lowerNetwork as any)) {
+  if (!(validNetworks as readonly string[]).includes(lowerNetwork)) {
     throw new Error(
       `Invalid STELLAR_NETWORK: "${network}". Must be one of: ${validNetworks.join(', ')}`
     )

src/middleware/adminAuth.ts

@@ -5,7 +5,7 @@ import db from '../db'
 import { logger } from '../utils/logger'
 import { recordAuthFailure } from '../utils/metrics'
 
-const prisma = db as any
+const prisma = db
 
 export interface AdminAuthContext {
   id: string

src/middleware/corsandbody.ts

@@ -115,12 +115,12 @@ export const urlencodedBodyParser = express.urlencoded({
  * this converts those into a consistent JSON response.
  */
 export function payloadSizeErrorHandler(
-  err: any,
+  err: unknown,
   _req: Request,
   res: Response,
   next: NextFunction
 ): void {
-  if (err.type === 'entity.too.large') {
+  if (err && typeof err === 'object' && 'type' in err && (err as Record<string, unknown>).type === 'entity.too.large') {
     res.status(413).json({
       success: false,
       error: 'Payload Too Large',

src/middleware/errorHandler.ts

@@ -20,7 +20,7 @@ export function errorHandler(
   const isDevelopment = process.env.NODE_ENV === 'development'
   const errorResponse = ErrorResponses.internalError(
     'Internal server error',
-    requestId,
+    requestId ?? 'unknown',
     isDevelopment ? { message: err.message } : undefined
   )
 

src/middleware/rateLimiter.ts

@@ -1,4 +1,10 @@
 import { type Request, type Response, type NextFunction } from 'express'
+
+interface RateLimitRequest extends Request {
+  rateLimit?: {
+    resetTime?: Date;
+  };
+}
 import rateLimit from 'express-rate-limit'
 import { config } from '../config/env'
 import { recordRateLimitHit } from '../utils/metrics'
@@ -64,8 +70,8 @@ function getRouteGroup(path: string): string {
  * Handler called when rate limit is exceeded. Sets Retry-After before responding.
  */
 function handleRateLimitExceeded(
-  req: any,
-  res: any,
+  req: RateLimitRequest,
+  res: Response,
   options: { limiterType: string; windowMs: number }
 ): void {
   const routeGroup = getRouteGroup(req.path)
@@ -117,7 +123,7 @@ export function buildRateLimiter(
     legacyHeaders: false,
     skip: opts.skip,
     message: { error: opts.message ?? 'Too many requests. Please try again later.' },
-    handler: (req: any, res: any) =>
+    handler: (req: RateLimitRequest, res: Response) =>
       handleRateLimitExceeded(req, res, {
         limiterType: opts.limiterType,
         windowMs: opts.windowMs,

src/middleware/validate.ts

@@ -9,10 +9,10 @@ export interface ValidationSchemas {
   errorMessage?: string;
 }
 
-type SchemasOrSchema = ValidationSchemas | ZodSchema<any> | ZodTypeAny;
+type SchemasOrSchema = ValidationSchemas | ZodTypeAny;
 
-function isZodSchema(val: any): val is ZodSchema<any> | ZodTypeAny {
-  return val && typeof val.safeParseAsync === 'function';
+function isZodSchema(val: unknown): val is ZodTypeAny {
+  return val !== null && typeof val === 'object' && 'safeParseAsync' in val && typeof (val as Record<string, unknown>).safeParseAsync === 'function';
 }
 
 function formatZodErrors(err: ZodError) {
@@ -37,7 +37,7 @@ export const validate = (schemasOrSchema: SchemasOrSchema) => {
         }
 
         // Merge parsed results back into req if present
-        const data: any = parsed.data || {};
+        const data = (parsed.data ?? {}) as Record<string, unknown>;
         if (data.body !== undefined) req.body = data.body;
         if (data.query !== undefined) Object.defineProperty(req, 'query', { value: data.query, writable: true, configurable: true });
         if (data.params !== undefined) Object.defineProperty(req, 'params', { value: data.params, writable: true, configurable: true });

src/routes/admin.ts

@@ -10,21 +10,22 @@
  */
 
 import { Router, Request, Response } from 'express'
+import type { Prisma } from '@prisma/client'
 import { getEventMetrics } from '../stellar/events'
 import { DeadLetterQueue } from '../stellar/dlq'
 import { logger } from '../utils/logger'
 import { requireAdminAuth, requireAdminScope } from '../middleware/adminAuth'
 import db from '../db'
 
 const router = Router()
-const prisma = db as any
+const prisma = db
 
 function auditLog(
   req: Request,
   res: Response,
   action: string,
   result: string,
-  details?: Record<string, any>,
+  details?: Record<string, unknown>,
 ): void {
   const adminAuth = res.locals.adminAuth
   const auditPayload = {
@@ -52,7 +53,7 @@ function auditLog(
           action,
           target: req.originalUrl || req.path,
           result,
-          details,
+          details: details as unknown as Prisma.InputJsonValue,
           ipAddress: req.ip,
           userAgent: req.get('user-agent') || null,
           method: req.method,
@@ -168,14 +169,14 @@ router.get(
       if (timeRangeStart) {
         const startDate = new Date(timeRangeStart as string)
         if (!isNaN(startDate.getTime())) {
-          filtered = filtered.filter(e => e.createdAt >= startDate)
+          filtered = filtered.filter(e => new Date(e.createdAt) >= startDate)
         }
       }
 
       if (timeRangeEnd) {
         const endDate = new Date(timeRangeEnd as string)
         if (!isNaN(endDate.getTime())) {
-          filtered = filtered.filter(e => e.createdAt <= endDate)
+          filtered = filtered.filter(e => new Date(e.createdAt) <= endDate)
         }
       }
 
@@ -605,9 +606,10 @@ router.post(
         },
         timestamp: new Date().toISOString(),
       })
-    } catch (error: any) {
+    } catch (error: unknown) {
       // Unique constraint violation — name already taken
-      if (error?.code === 'P2002') {
+      const prismaError = error as { code?: string };
+      if (prismaError?.code === 'P2002') {
         return res.status(409).json({ success: false, error: 'A key with that name already exists' })
       }
       logger.error('[Admin] Failed to create admin key', {
@@ -631,7 +633,7 @@ router.delete(
   requireAdminScope('keys:write'),
   async (req: Request, res: Response) => {
     try {
-      const { id } = req.params
+      const id = req.params.id as string
 
       const existing = await prisma.adminApiKey.findUnique({
         where: { id },
@@ -647,7 +649,7 @@ router.delete(
       }
 
       await prisma.adminApiKey.update({
-        where: { id },
+        where: { id: id },
         data: { revokedAt: new Date() },
       })