Add prometheus alerting rule for agent loop consecutive failures#248
Open
oyinade247 wants to merge 2 commits into
Open
Conversation
…th specific types and unknown
…tion and Prometheus alerting rules
|
@oyinade247 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #224
Summary
Add agent loop health monitoring with Prometheus metrics, alerting rules, and CI validation.
Changes
Metrics (
src/utils/metrics.ts)agent_loop_errors_total(Counter) — incremented on each loop tick failureagent_loop_last_success_timestamp(Gauge) — set on each successful loop tickInstrumentation (
src/agent/loop.ts)recordAgentLoopSuccess()on success paths inrebalanceCheckJobandsnapshotJobrecordAgentLoopError()on each catch blockAlerting rules (
deploy/monitoring/prometheus/alert-rules.yaml)AgentLoopConsecutiveFailuresincrease(agent_loop_errors_total[5m]) > 3for 2mAgentLoopStalledtime() - agent_loop_last_success_timestamp > 600for 2mDLQDepthHighdlq_size > 50for 1mEach new alert includes a
runbook_urlannotation.CI validation (
.github/workflows/k8s-validate.yml)deploy/monitoring/**added to push/PR trigger pathspromtool check rulesstep added to validate alert rules