Add lartg to compute Givens/Jacobi rotations#18
Open
alecarraro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, last week I talked to @Rabab53 about implementing primitives for Jacobi SVD/Diagonalization methods in
NextLA. As a first step in this direction I am addinglartg, to compute Givens/Jacobi rotations.The implementation follows the safe-scaling algorithm by Anderson [1], which is also used in LAPACK. The function
lartgis in fact meant to cover all four LAPACKxLartgvariants [2]. I also added a small helper to compare the results against these.LAPACK also implements the batched version, but I don't think it should be added here since it doesn't map well to GPU execution (as it would result in massive warp-divergence).
For testing, I haven’t added coverage across different backends, since this just a scalar-to-scalar primitive. Let me know if you'd prefer a different approach