Draft -hackers reply: logging-destination wait events (testing + review)#50
Closed
NikolayS wants to merge 1 commit into
Closed
Draft -hackers reply: logging-destination wait events (testing + review)#50NikolayS wants to merge 1 commit into
NikolayS wants to merge 1 commit into
Conversation
Draft response to the "Add wait events for server logging destination writes" thread, with Linux + Windows runtime testing results and a code review of v4. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLCS79xbABNmQ4pbLQ3gZ4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
email-draft-logging-waitevents.txt— a draft pgsql-hackers reply to the "Add wait events for server logging destination writes" thread.The draft covers what Seongjun is holding v5 for (Nikolay's Linux + Windows testing) plus a code review of v4:
Testing
windows-waitevents.yml, MSVC/meson) confirmedIO/EventlogWriteappears inpg_stat_activityat runtime (closes the one open item from the v4 posting);StderrWrite/WriteConsoleWpath exercised.logspam(50000), ~20 ms sampling for 20 s:logging_collector=on→IO/SysloggerWrite46.3%logging_collector=off→IO/StderrWrite17.6%Code review — both
write()sites inwrite_pipe_chunkswrapped,write_consoleleaf, bothsyslog()sites; positions taken on the open items (keep names + add thewrite_syslogger_fileclarifying comment, follow the single-slot convention rather than save/restore, leaveEventlogWritecross-platform).This PR is documentation/review material only — no source changes. Not for merge; the draft is for posting to the mailing list.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KLCS79xbABNmQ4pbLQ3gZ4
Generated by Claude Code