Skip to content

Add directory argument#2

Open
jacob-israel-turner wants to merge 12 commits into
NishanthShankar:masterfrom
FreeplayApp:master
Open

Add directory argument#2
jacob-israel-turner wants to merge 12 commits into
NishanthShankar:masterfrom
FreeplayApp:master

Conversation

@jacob-israel-turner

Copy link
Copy Markdown

Hey @NishanthShankar! Thanks for creating this cool little action - we've put it to good use!

We have recently migrated to a mono-repo, and need to run the release-react command in a directory that isn't root. I initially tried using Github Actions' working-directory option, but that does not work in conjunction with uses or with I ended up forking this action and making it work for our use-case - this is what I came up with.

I'd love to get this merged back upstream if you find this would be an acceptable and valuable addition. If that's the case, let me know and I'll clean up this PR and remove irrelevant changes. I'm also not super experienced in bash, so if you have a cleaner approach, I'm all ears!

If this is not an API you want to add, that's fine - I'm happy to continue using our fork.

Thanks!

@jacob-israel-turner

Copy link
Copy Markdown
Author

@NishanthShankar This PR is dropping off my radar, but I'll leave it open in case you want to merge it in. Feel free to comment here and I'll try to jump back in if you have any feedback/requests.

@grndvl1

grndvl1 commented Apr 29, 2022

Copy link
Copy Markdown

Not sure what you need the directory for. I personally have been having issues with getting any of these to work for appcenter, seems I can't find the apk. Even using a file search for a step it can't find it. None of these forks allow issues so this is my only way to communicate that I can't get these to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants