Add directory argument#2
Open
jacob-israel-turner wants to merge 12 commits into
Open
Conversation
Author
|
@NishanthShankar This PR is dropping off my radar, but I'll leave it open in case you want to merge it in. Feel free to comment here and I'll try to jump back in if you have any feedback/requests. |
|
Not sure what you need the directory for. I personally have been having issues with getting any of these to work for appcenter, seems I can't find the apk. Even using a file search for a step it can't find it. None of these forks allow issues so this is my only way to communicate that I can't get these to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @NishanthShankar! Thanks for creating this cool little action - we've put it to good use!
We have recently migrated to a mono-repo, and need to run the release-react command in a directory that isn't root. I initially tried using Github Actions'
working-directoryoption, but that does not work in conjunction withusesorwithI ended up forking this action and making it work for our use-case - this is what I came up with.I'd love to get this merged back upstream if you find this would be an acceptable and valuable addition. If that's the case, let me know and I'll clean up this PR and remove irrelevant changes. I'm also not super experienced in bash, so if you have a cleaner approach, I'm all ears!
If this is not an API you want to add, that's fine - I'm happy to continue using our fork.
Thanks!