Add workflow-security CI gate (zizmor + pinact) and Dependabot cooldown#61
Merged
Conversation
Delay update PRs for freshly published releases by 7 days, so a compromised release has time to be caught and yanked before Dependabot auto-adopts it (zizmor dependabot-cooldown).
Add a workflow-security job to check.yml that runs on every PR and push: - nix run .#zizmor -- .github/ audits all workflows, the composite action, and dependabot.yml. - nix run .#pinact -- run --check verifies every action is SHA-pinned and its version comment matches the SHA.
Artifact comparison0 modified · 0 added · 0 deleted · 96 unchanged Download report — HTML file; open in a browser. Compared
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a CI gate that runs zizmor + pinact over
.github/on every PR and push, plus a Dependabot cooldown. This is the guardrail for the workflow-hardening series (#55, #58, #59, #60) — it keeps those fixes from silently regressing.check.yml— newworkflow-securityjob:nix run .#zizmor -- .github/— audits all workflows, the composite action, anddependabot.yml.nix run .#pinact -- run --check— verifies every action is SHA-pinned and its# vX.Y.Zcomment matches the SHA.dependabot.yml—cooldown: { default-days: 7 }: delays adopting a freshly published release for 7 days so a compromised release can be caught/yanked first.Why
The hardening PRs fixed these by hand; without a gate a future PR could reintroduce an unpinned action, a
${{ }}shell injection, an over-broad permission, or drifted pins. zizmor + pinact catch all of those in CI.Notes
known-vulnerable-actionsCVE check). CI uses only the pinned version with a fresh HTTP cache, so it's reliable; the sole dependency is GitHub API reachability at run time.dependabot-cooldownaudit, so the gate doesn't yet enforce the cooldown — the fix is proactive and will be enforced onceflake.lock's nixpkgs is next bumped.Verification
actionlint: cleannix run .#zizmor -- .github/(pinned 1.18.0, online): exit 0, no findingsnix run .#pinact -- run --check(pinned 3.4.5): exit 0dependabot.yml: valid YAML