Attest build provenance for release artifacts#64
Merged
Conversation
Sign the GitHub release artifacts (the branding guide PDF and the public logos in result-assets) with actions/attest-build-provenance, so consumers can verify their origin with `gh attestation verify <file> -R NixOS/branding`. Grants the release job id-token: write + attestations: write (both scoped to that job). Complements the npm package's trusted-publishing provenance — now both distribution channels carry verifiable provenance.
Artifact comparison0 modified · 0 added · 0 deleted · 96 unchanged Download report — HTML file; open in a browser. Compared
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a signed build-provenance attestation for the GitHub release artifacts (the branding guide PDF + the public logos in
result-assets), using GitHub's officialactions/attest-build-provenance.Attest build provenancestep in thereleasejob, right after buildingresult-assets.releasejobid-token: write+attestations: write(scoped to that job, alongside the existingcontents: write).Why
The npm package already gets provenance via npm trusted publishing (OIDC); this closes the same gap for the GitHub release channel. After a release, anyone can verify an artifact came from this repo's workflow:
It's GitHub-native (Sigstore-backed) — no third-party service.
Verification
actionlint: cleanpinact run --check: clean (newattest-build-provenancepinned tov4.1.1/0f67c3f…)zizmor .github/(regular gate): 0 findingszizmor --pedantic .github/: 0 findingsNot verified
The step only runs on an actual tag-push release, which can't be exercised locally.
subject-path: result-assets/*globs the built artifacts (symlinks into the Nix store — the same pathsgh release createalready uploads); worth confirming on the next release that it produces attestations for the expected files.