rhai-lsp: init at 0-unstable-2022-10-25

[yzhou216]

Resolves #433006

cc @matthiasbeyer for testing

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[yzhou216]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 434339

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/17014400811

Download packages from cache:

• x86_64-linux

  nix-store -r --add-root nixpkgs-pr-434339-x86_64-linux \
    --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
    --option trusted-public-keys '
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
    ' \
    /nix/store/y84mrnvz1nlqzldxgn6brld6p3k1znca-rhai-lsp-0-unstable-2022-10-25

• aarch64-linux

  nix-store -r --add-root nixpkgs-pr-434339-aarch64-linux \
    --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
    --option trusted-public-keys '
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
    ' \
    /nix/store/pv64hnbk6z8q02i9wjm2i89fq8dd8qy4-rhai-lsp-0-unstable-2022-10-25

• x86_64-darwin

  nix-store -r --add-root nixpkgs-pr-434339-x86_64-darwin \
    --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
    --option trusted-public-keys '
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
    ' \
    /nix/store/0vx78ysp6z1lwk7y9bckzaajbf18v47a-rhai-lsp-0-unstable-2022-10-25

• aarch64-darwin

  nix-store -r --add-root nixpkgs-pr-434339-aarch64-darwin \
    --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
    --option trusted-public-keys '
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
    ' \
    /nix/store/cav4gjx9dk45a4n369lgxvpcspvlaz2h-rhai-lsp-0-unstable-2022-10-25

---

x86_64-linux

✅ 1 package built:

• rhai-lsp

---

aarch64-linux

✅ 1 package built:

• rhai-lsp

---

x86_64-darwin (sandbox = true)

✅ 1 package built:

• rhai-lsp

---

aarch64-darwin (sandbox = true)

✅ 1 package built:

• rhai-lsp

[matthiasbeyer]

Awesome! I think we should PR the Cargo.lock file to upstream, what do you think?

[matthiasbeyer]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434339
Commit: b9f8691e0adeb09a1e253de7caf104ecc470a58d

---

x86_64-linux

✅ 1 package built:

• rhai-lsp

[matthiasbeyer]

Approved automatically following the successful run of nixpkgs-review.

[yzhou216]

Awesome! I think we should PR the Cargo.lock file to upstream, what do you think?

The upstream hasn't updated for 3 years now, I'm not sure if this is worth it.

[matthiasbeyer]

Okay, then please replace the lockfile here with the patch from rhaiscript/lsp#108

[yzhou216]

Okay, then please replace the lockfile here with the patch from rhaiscript/lsp#108

What's different from adding a Cargo.lock along with the derivation? Is there a preferred way to do this in Nixpkgs?

[matthiasbeyer]

I think patch is preferred, because it does not check in thousand of lines into nixpkgs.

[yzhou216]

I think patch is preferred, because it does not check in thousand of lines into nixpkgs.

  patches = [
    (fetchpatch {
      name = "add-cargo-lock.patch";
      url = "https://github.com/rhaiscript/lsp/commit/77bd9052297d74320d84c7fcaa3fe75ddc211543.patch";
      sha256 = "";
    })
  ];

I just tried to use fetchpatch. I don't think it works because cargoHash has to be used with Cargo.lock and patchPhase happens after that. Any idea how to get around that?

[matthiasbeyer]

Meeeeh I forgot about that. Maybe we should just wait for rhaiscript/lsp#108

[matthiasbeyer]

Upstream refuses to include a lockfile, so I would say we rather not include the package than committing thousand of lines to nixpkgs. What do you think?

[yzhou216]

Upstream refuses to include a lockfile, so I would say we rather not include the package than committing thousand of lines to nixpkgs. What do you think?

Seems like that's the only choice.

Wouldn't the lock file be regenerated upon build if it is not included?

I didn't see this one coming, tho, lol. Don't know what to say tbh... I guess people are just not into build systems and don't understand how they work?

[matthiasbeyer]

I guess people are just not into build systems and don't understand how they work?

Yep.

I suggest we close this then, upstream is not interested in anyone using their software, it seems. 😢

[yzhou216]

I guess people are just not into build systems and don't understand how they work?

Yep.

I suggest we close this then, upstream is not interested in anyone using their software, it seems. 😢

I agree. Closing.