Skip to content

fix(deps): update dependency markdown-it to v14 [security]#585

Open
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/npm-markdown-it-vulnerability
Open

fix(deps): update dependency markdown-it to v14 [security]#585
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/npm-markdown-it-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
markdown-it ^12.0.0^14.0.0 age confidence

markdown-it: Quadratic complexity DoS in smartquotes rule via replaceAt string operations

CVE-2026-48988 / GHSA-6v5v-wf23-fmfq

More information

Details

Summary

A quadratic time complexity vulnerability exists in markdown-it's smartquotes rule (enabled via the typographer: true option). An attacker can craft a markdown input consisting of consecutive quotation marks that causes the parser to consume excessive CPU time, leading to denial of service.

Details

The vulnerability is in the replaceAt() helper function used by the smartquotes rule in lib/rules_core/smartquotes.mjs:

function replaceAt (str, index, ch) {
  return str.slice(0, index) + ch + str.slice(index + 1)
}

When markdown-it processes a text token containing many quotation marks (either " or ') with typographer: true, the smartquotes rule iterates through each quote character and calls replaceAt() to substitute it with a typographic (curly) quote. Each call to replaceAt() creates three new string slices and concatenates them, which is an O(n) operation where n is the length of the string.

Since this is called once per quote character in the token, and there are n quote characters, the total time complexity becomes O(n^2).

The root cause is that the smartquotes rule modifies token.content in place using string slicing rather than building the result incrementally. The process_inlines() function (line 14) processes each quote in the text token, and for matching quote pairs, calls replaceAt() on both the opening and closing token's content (lines 151-152). When the entire input is a single text token of quote characters, this results in quadratic behavior.

PoC
const md = require('markdown-it');
const instance = md({ typographer: true });

// 160,000 consecutive double-quote characters
const payload = '"'.repeat(160000);

console.time('render');
instance.render(payload);
console.timeEnd('render');
// Output: render: ~21000ms (21 seconds)

// Compare with typographer disabled:
const safe = md({ typographer: false });
console.time('render-safe');
safe.render(payload);
console.timeEnd('render-safe');
// Output: render-safe: ~8ms

Measured timing on a modern system:

  • 10,000 quotes: ~19ms
  • 20,000 quotes: ~51ms
  • 40,000 quotes: ~212ms
  • 80,000 quotes: ~5,430ms
  • 160,000 quotes: ~21,198ms

The scaling is clearly superlinear (quadratic), with the 80K->160K step showing a ~3.9x increase for a 2x input increase, consistent with O(n^2).

Impact

Applications that render user-supplied markdown with typographer: true are vulnerable to denial of service. An attacker can submit a relatively small payload (160KB of quote characters) that causes the server to spend over 21 seconds processing a single request. Repeated submissions can exhaust server CPU resources and prevent legitimate users from being served.

The impact is mitigated by the fact that the typographer option defaults to false and must be explicitly enabled. However, the typographer feature is commonly enabled in production applications that want smart typography, and the markdown-it documentation prominently suggests enabling it.

A suggested fix would be to replace the replaceAt() approach with an array-based or StringBuilder-style approach that collects all replacements and applies them in a single pass, reducing the time complexity to O(n).

Severity

  • CVSS Score: 5.3 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

markdown-it/markdown-it (markdown-it)

v14.2.0

Compare Source

Added
  • isPunctCharCode to utilities.
Fixed
  • Don't end HTML comment blocks on a blank line, #​1155.
  • Properly recognize astral chars (surrogates) in delimiter scans for
    emphasis-like markers, #​1072. Big thanks to @​tats-u for his global efforts
    with improving CJK support.
  • Preserve unicode whitespaces when trimm headings/paragraphs, #​1074.
  • More strict entities decode to avoid false positives ;, #​1096.
  • Restore block parser state on fail in lheading rule, #​1131.
Security
  • Fixed poor smartquotes perfomance on > 70k quotes in single block
  • Bumped linkify-it to 5.0.1 with fixed potential perfomance issues.

v14.1.1

Compare Source

Security
  • Fixed regression from v13 in linkify inline rule. Specific patterns could
    cause high CPU use. Thanks to @​ltduc147 for report.

v14.1.0

Compare Source

Changed
  • Updated CM spec compatibility to 0.31.2, #​1009.
Fixed
  • Fixed quadratic complexity when parsing references, #​996.
  • Fixed quadratic output size with pathological user input in tables, #​1000.

v14.0.0

Compare Source

Changed
  • Drop ancient browsers support (use .fromCodePoint and other features).
  • Rewrite to ESM (including all plugins/deps). CJS fallback still available.
    No signatures changed, except markdown-it-emoji plugin.
  • Dropped dist/ folder from repo, build on package publish.
  • Set punicode.js as external dependency.
Fixed
  • Html tokens inside img alt are now rendered as their original text, #​896.
  • Hardbreaks inside img alt are now rendered as newlines.

v13.0.2

Compare Source

Security
  • Fixed crash/infinite loop caused by linkify inline rule, #​957.
Fixed
  • Throw an error if 3rd party plugin doesn't increment line or pos counters
    (previously, markdown-it would likely go into infinite loop instead), #​847.

v13.0.1

Compare Source

Fixed
  • Bumped linkify-it to 4.0.1. That should fix some hangs, caused by wrong
    data, returned from linkify-it.

v13.0.0

Compare Source

Added
  • Added a new token type text_special to store escaped characters, same as text but
    unaffected by replacement plugins (smartquotes, typographer, linkifier, etc.).
  • Added a new rule text_join in core ruler. Text replacement plugins may choose to
    insert themselves before it.
Changed
  • (p) is no longer replaced with § by typographer (conflicts with ℗), #​763.
  • text_collapse rule is renamed to fragments_join.
Fixed
  • Smartquotes, typographic replacements and plain text links can now be escaped
    with backslash (e.g. \(c) or google\.com are no longer replaced).
  • Fixed collision of emphasis and linkifier (so http://example.org/foo._bar_-_baz
    is now a single link, not emphasized). Emails and fuzzy links are not affected by this.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants