Fix stale state after collection drop and re-create#203
Merged
Conversation
…ilures Route shared on-disk L1 checkpoint/partition reclaim (vector, spatial, sparse-vector, timeseries) to a single homing core per collection during the all-cores UnregisterCollection fan-out, since those paths are keyed by (database, tenant, collection) rather than by core and concurrent cores racing remove_dir_all/unlink on the same tree could turn a benign concurrent-removal errno into a fatal barrier failure. Other cores still evict their own per-core in-memory state. Replace the untyped reclaim error with ReclaimFailure, which records whether a durable pending_reclaim retry record was persisted. Callers now disarm their lifecycle guard only when a retry owner exists; otherwise the guard's unwind Drop releases the in-memory drain so a same-name CREATE can self-heal off the durable inactive catalog row instead of wedging behind an orphaned hold. Also make catalog existence checks in collection/materialized-view CREATE abort on a read fault rather than silently treating it as "does not exist".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --all --checkcargo check -p nodedb --all-targetscargo clippy -p nodedb --lib -- -D warningscargo nextest run -p nodedb-walcargo nextest run -p nodedb --test sql_drop_collectioncargo nextest run -p nodedb --test sql_materialized_view_refreshAll-target clippy also reaches an unrelated pre-existing
manual_is_multiple_oflint innodedb/tests/native_txn_commit_visibility.rs:89.Fixes #199