Skip to content

define WIN32 on windows builds#54

Merged
Nomagno merged 1 commit into
Nomagno:tyre2X-devfrom
nutzboi:tyre2X-dev
Apr 5, 2026
Merged

define WIN32 on windows builds#54
Nomagno merged 1 commit into
Nomagno:tyre2X-devfrom
nutzboi:tyre2X-dev

Conversation

@nutzboi

@nutzboi nutzboi commented Apr 4, 2026

Copy link
Copy Markdown

Improves (not sure / haven't tested if it replaces) what 6c23f94 achieves. It had broken in the first place because the macro WIN32 was deprecated and replaced only with _WIN32 on most compilers. This commit explicitly defines WIN32 in CMakeLists (along with the kimden-defined WIN_BUILD) when compiling with MSVC or MINGW.

This fixes music being broken in the game for me. 9d8cecc can also now be reverted lol.

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

improves what 6c23f94 was supposed to achieve. 9d8cecc can also now be reverted.
@Nomagno Nomagno merged commit 12fe79b into Nomagno:tyre2X-dev Apr 5, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants