Skip to content

#3995 blank design review title #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wavehassman merged 4 commits into from
May 27, 2026
+2 −3
Merged

#3995 blank design review title #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61a68eb
#4039-NatashaJoshi-credits
natashajoshi23 Apr 2, 2026
3d39e77
#3995 blank dr title
staysgt May 25, 2026
70e473a
#4039 check title whitespace backend
staysgt May 26, 2026
9d1fc6f
#4039 move logic to validation util
staysgt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/backend/src/utils/validation.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ export const decimalMinZero = (validationObject: ValidationChain): ValidationCha
.withMessage('Value must be greater than or equal to zero');
};

//Const to return if an input is a string and is not empty
export const nonEmptyString = (validationObject: ValidationChain): ValidationChain => {
return validationObject.isString().not().isEmpty();
return validationObject.isString().not().isEmpty({ ignore_whitespace: true });
};

export const isRole = (validationObject: ValidationChain): ValidationChain => {
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/pages/CalendarPage/Components/EventModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export interface EventPayload {
}

const schema = yup.object().shape({
title: yup.string().required('Title is required'),
title: yup.string().required('Title is required').trim().min(1, 'Title cannot be only whitespace'),
eventTypeId: yup.string().required('Event Type is required'),
requiredMemberIds: yup.array().of(yup.string().required()).default([]),
optionalMemberIds: yup.array().of(yup.string().required()).default([]),
Expand Down
Loading