feat: add clear (×) button to target input (closes #197)#210
Open
Maqbool61 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a small clear button inside the target input that appears when there is text and empties the field on click — handy on mobile where selecting-all-and-deleting is fiddly.
Changes (
frontend/src/components/Sidebar.tsx)Xto lucide-react imports<input>in arelativedivpr-7padding to the input whentargethas text so the clear button never overlaps the typed content{target && ...}), positionedabsolute right-2 top-1/2 -translate-y-1/2setTarget(''),aria-label="Clear target"for accessibilityVerified
How to test
×button appears on the rightCloses #197