feat: Implement diffing algorithm for MapTemplates#17
Open
Restioson wants to merge 1 commit into
Open
Conversation
Author
|
This could probably be optimised somewhat by keeping the hash on the entire template rather than each MapChunk, but this would somewhat weaken encapsulation. I don't really have the bandwidth to change it and it's a minor optimisation for a use-case that isn't very performance-critical (reloading). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a very coarse diffing algorithm for map templates. It is intended to be used with NucleoidMC/plasmid#293 as such:
The functionality offered is therefore pretty much the bare minimum to support that use case.
The diffing algorithm uses the BLAKE3 hash function internally to compare
MapChunks.It takes around 100ms to hash a map that takes 400ms to load (based on siege:jungle). Therefore, the first hot reload of the map would take 100ms (hash old map) + 400ms (load new map) + 100ms (hash new map) + (negligible comparison) = 600ms. On second reload, the old map doesn't need to be hashed, so it would be 500ms.